Project

General

Profile

Actions

Bug #100197

closed

Remove HTTP_REFERER validity check or logging

Added by Torben Hansen about 1 year ago. Updated 11 months ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
felogin
Target version:
-
Start date:
2023-03-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With #99920 the HTTP_REFERER check has been fixed. The patch introduced a validity check for the HTTP_REFERER using the $this->redirectUrlValidator->isValid($referer), which however logs warnings if the checked redirect URL is not considered as valid.

So either the check must be removed or the logging.

As an addition, the evaluation of the referer could only be processed, if redirectMode is either referer or refererDomains. This was the previous behavior in ext:felogin, but seems most likely to have been forgotten to be implemented in the extbase version of ext:felogin.

Logging for the validator can temporarily be disabled by adding the following to AdditionalConfiguration.php

$GLOBALS['TYPO3_CONF_VARS']['LOG']['TYPO3']['CMS']['FrontendLogin']['Validation']['RedirectUrlValidator']['writerConfiguration'][\TYPO3\CMS\Core\Log\LogLevel::WARNING] = [];

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #100715: felogin redirect mode by http referer is not workingResolvedTorben Hansen2023-04-23

Actions
Actions #1

Updated by Torben Hansen about 1 year ago

We switch loglevel to DEBUG

Actions #2

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78169

Actions #3

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78733

Actions #4

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78733

Actions #5

Updated by Torben Hansen about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Chris Müller about 1 year ago

  • Related to Bug #100715: felogin redirect mode by http referer is not working added
Actions #7

Updated by Markus Klein 11 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF