Bug #100348: ckeditor 5 does not allow styling of UL/OL elements - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #100348

closed

Epic #99669: CKEditor5 Collection

ckeditor 5 does not allow styling of UL/OL elements

Added by Sven Carstens about 1 year ago. Updated 8 months ago.

Status:

Resolved

Priority:

Should have

Assignee:

Category:

RTE (rtehtmlarea + ckeditor)

Target version:

next-patchlevel

Start date:

2023-03-29

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

ckeditor 4 did allow for the styling of UL/OL via css classes.
Applying the following configuration in ckeditor 5 will only allow to style the individial LI elements or a complete P element.

editor:
    config:
        style:
            definitions:
                - { name: "✓ Checkmarks UL", element: "ul", classes: ['list-unordered-checkmarks'] }
                - { name: "✓ Checkmarks P", element: "p", classes: ['list-unordered-checkmarks'] }
                - { name: "✓ Checkmarks LI", element: "li", classes: ['list-unordered-checkmarks'] }

Seems to be a general problem with ckeditor 5 not yet supporting this (and other) use-cases.

Related drupal issue https://www.drupal.org/project/drupal/issues/3326261

Files

ckeditor5-bundle.js.patch (1.13 KB) ckeditor5-bundle.js.patch

Hendrik N, 2023-06-14 10:33

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Marc Hirdes 11 months ago

Seems to be fixed in CKEditor Version 38 https://github.com/ckeditor/ckeditor5/issues/14200#issuecomment-1556760672

Actions

Copy link

Updated by Tymoteusz Motylewski 11 months ago

Related to Task #100908: Update ckeditor5 to 38.0 added

Actions

Copy link

Updated by Tymoteusz Motylewski 11 months ago

here is a patch which upgrades ckeditor to v38
https://review.typo3.org/c/Packages/TYPO3.CMS/+/79133
please confirm whether it solves the issue for you

Actions

Copy link

Updated by Marc Hirdes 11 months ago

Thanks for the fast patch. But I still can not select the style. I also get a JS error:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'attach') at VM493 ckeditor5.js:21:1151

Actions

Copy link

Updated by Benni Mack 11 months ago

Target version changed from 12 LTS to Candidate for patchlevel

Actions

Copy link

Updated by Hendrik N 11 months ago

File ckeditor5-bundle.js.patch ckeditor5-bundle.js.patch added

As mentioned here https://github.com/ckeditor/ckeditor5/issues/14200#issuecomment-1589006697 the fix is only for "DocumentList", not for "List" (which is imported in Build/Sources/JavaScript/rte_ckeditor/contrib/ckeditor5-bundle.js)

The attached patch fixes the issse.

Actions

Copy link

Updated by Gerrit Code Review 10 months ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79701

Actions

Copy link

Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79701

Actions

Copy link

Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79701

Actions

Copy link

#10

Updated by Andreas Steiner 10 months ago

Target version changed from Candidate for patchlevel to next-patchlevel

Actions

Copy link

#11

Updated by Gerrit Code Review 8 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80689

Actions

Copy link

#12