Project

General

Profile

Actions

Bug #100477

open

translateFormElementError() calls getProperties() on RootRenderableInterface

Added by Christian Kuhn about 1 year ago. Updated about 1 year ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2023-04-05
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

See TranslationServiceTest->translateFormElementErrorTranslateErrorFromFormWithContentElementUidIfFormContainsOriginalIdentifier() and translateFormElementErrorTranslateErrorFromFormWithContentElementUidIfFormContainsNoOriginalIdentifier()

TranslationService->translateFormElementError() calls getProperties() on RootRenderableInterface, but the method is not part of the interface.

Something is wrong here, but I lack deeper understanding currently:
  • Should getProperties() be added to the interface?
  • Should translateFormElementError() sanitize that and check differently, maybe similar to other methods in the class?

Note TranslateElementErrorViewHelper uses the method, too.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #100478: Avoid invalid methods in TranslationServiceTestClosed2023-04-05

Actions
Actions #1

Updated by Christian Kuhn about 1 year ago

  • Related to Task #100478: Avoid invalid methods in TranslationServiceTest added
Actions #2

Updated by Christian Kuhn about 1 year ago

  • Description updated (diff)
Actions

Also available in: Atom PDF