Project

General

Profile

Actions

Bug #100929

closed

Typoscript config controlsList=nodownload not possible!

Added by Heiko Dietrich 11 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
Start date:
2023-05-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
7.4
Tags:
viewhelper
Complexity:
medium
Is Regression:
Sprint Focus:
Stabilization Sprint

Description

Typoscript config not possible:

lib.contentElement.settings.media.additionalConfig.controlsList=nodownload

rendering will give 2 attributes

<video .... controlsList controlsList="nodownload"><source src="...." type="video/mp4"></video>

Reason is a doublet Foreach in \TYPO3\CMS\Core\Resource\Rendering\VideoTagRenderer::render-Method

  if (isset($options['additionalConfig']) && is_array($options['additionalConfig'])) {
            foreach ($options['additionalConfig'] as $key => $value) {
                if ((bool)$value) {
                    $attributes[] = htmlspecialchars($key);
                }
            }
        }

        foreach (['class', 'dir', 'id', 'lang', 'style', 'title', 'accesskey', 'tabindex', 'onclick', 'controlsList', 'preload'] as $key) {
            if (!empty($options[$key])) {
                $attributes[] = $key . '="' . htmlspecialchars($options[$key]) . '"';
            }
        }
Actions #1

Updated by Heiko Dietrich 11 months ago

Easiest solution couldt be, if use:

 $attributes[$key] = ...  

instead of
$attributes[] = ...

Actions #2

Updated by Oliver Hader 11 months ago

  • Status changed from New to Accepted
Actions #3

Updated by Oliver Hader 11 months ago

  • Category changed from Frontend to Fluid
Actions #4

Updated by Benni Mack 11 months ago

  • Sprint Focus set to Stabilization Sprint
Actions #5

Updated by Gerrit Code Review 10 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79615

Actions #6

Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79615

Actions #7

Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79615

Actions #8

Updated by Gerrit Code Review 10 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79615

Actions #9

Updated by Gerrit Code Review 10 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79615

Actions #10

Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79638

Actions #11

Updated by Benni Mack 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #12

Updated by Gerrit Code Review 10 months ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79638

Actions #13

Updated by Benni Mack 10 months ago

  • Status changed from Under Review to Resolved
Actions

Also available in: Atom PDF