Project

General

Profile

Actions

Bug #101113

closed

System reports will show that there are no redirects conflicts even if the checkintegrity command was never run

Added by Sybille Peters 11 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Should have
Category:
Redirect Handling
Target version:
-
Start date:
2023-06-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Update : the implementation in the patch is a little different than described here: We create an additional status if checkintegrity was not run or is outdated. The status which shows ok or redirects is still displayed.


Ideally the "reports" checks if checkintegrity was run lately (e.g. within last 24 hours) and

  • if checkintegrity was run and no conflicts: OK
  • no redirects exist: OK
  • if checkintegrity was not run (lately) and no conflicts (known): WARNING or INFO, e.g. "there are no known redirect conflicts, please run checkintegrity"
  • if there are conflicts: WARNING (as before)

Reproduce

1. Create conflicts (e.g. rename slug of page twice)
2. confirm conflict by loading the page and check TYPO3 log (in case of redirect to self there will be something like " Redirect /styleguide-demo-1/test/redrects points to itself! Aborting" in log
3. look in report: will show OK. No indication that this is incorrect or something needs to be done.
4. confirm checkintegrity finds something (will show 1 conflict):

 php typo3/sysext/core/bin/typo3 redirects:checkintegrity

I expect a WARNING instead of OK status in report if there are conflicts and checkintegrity was never used or not used recently.

Screenshots (current core version)

Status: "Ok" (blissfully unaware of pending doom)

Status: after running checkintegrity

also, the text is weird, but that's another issue.

Screenshot (implementation, see patch)

This is current version in patch, not in core!:


Files

redirects_report_ok.png (5.1 KB) redirects_report_ok.png Sybille Peters, 2023-06-17 09:16
redirect_reports_conflicts.png (21.5 KB) redirect_reports_conflicts.png Sybille Peters, 2023-06-17 09:22
redirect_reports_patch.png (31.2 KB) redirect_reports_patch.png Sybille Peters, 2023-06-17 11:49

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Feature #99485: Show the redirect integrity statusClosedGuido Schmechel2023-01-07

Actions
Related to TYPO3 Core - Task #102037: Fix rendering warning in redirects system extensionClosedChris Müller2023-09-25

Actions
Actions #1

Updated by Gerrit Code Review 11 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452

Actions #2

Updated by Gerrit Code Review 11 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452

Actions #3

Updated by Gerrit Code Review 11 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452

Actions #4

Updated by Gerrit Code Review 11 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452

Actions #5

Updated by Sybille Peters 11 months ago

Actions #6

Updated by Gerrit Code Review 11 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452

Actions #7

Updated by Gerrit Code Review 11 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452

Actions #8

Updated by Gerrit Code Review 11 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452

Actions #9

Updated by Gerrit Code Review 11 months ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452

Actions #10

Updated by Gerrit Code Review 10 months ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452

Actions #11

Updated by Sybille Peters 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #12

Updated by Chris Müller 7 months ago

  • Related to Task #102037: Fix rendering warning in redirects system extension added
Actions

Also available in: Atom PDF