Project

General

Profile

Actions
Copy link

Bug #101243

closed

Fix in linkvalidator PagesRepository::doesRootLineContainHiddenPages

Added by Sybille Peters 10 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
Sybille Peters
Category:
Linkvalidator
Target version:
-
Start date:
2023-07-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

PagesRepository::doesRootlineContainHiddenPages() calls itself. It fetches fields from the DB without "pid" and passes the results to itself, then checks the value of pid, but this is always empty.

PagesRepository code:

42 public function doesRootLineContainHiddenPages(array $pageInfo): bool
43 {
44        $pid = (int)($pageInfo['pid'] ?? 0);

....

59 $row = $queryBuilder
60            ->select('uid', 'title', 'hidden', 'extendToSubpages')

....

72 return $this->doesRootLineContainHiddenPages($row);

Also, it is not necessary to get the title here

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #93895: Linkvalidator report doesn't list discovered bad links if the page is hiddenResolved2021-04-09

Actions
Actions
Copy link
 #1

Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79724

Actions
Copy link
 #2

Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79724

Actions
Copy link
 #3

Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79724

Actions
Copy link
 #4

Updated by Gerrit Code Review 10 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79724

Actions
Copy link
 #5

Updated by Sybille Peters 9 months ago

  • Related to Bug #93895: Linkvalidator report doesn't list discovered bad links if the page is hidden added
Actions
Copy link
 #6

Updated by Gerrit Code Review 9 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79724

Actions
Copy link
 #7

Updated by Gerrit Code Review 9 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79724

Actions
Copy link
 #8

Updated by Gerrit Code Review 5 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79724

Actions
Copy link
 #9

Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81831

Actions
Copy link
 #10

Updated by Sybille Peters 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF