Project

General

Profile

Actions

Bug #101432

closed

f:link.page "target" attribute not respected

Added by Daniel Corn 9 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2023-07-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.2
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

If I specify the "target"-attribute on a <f:link.page> node it will be overwritten with _self.

<f:link.page pageUid="{settings.pages.homePageUID}" 
             additionalAttributes="{'data-target':'home'}" 
             target="home"></f:link.page>

It looks like my attributes are overwritten by the attributes coming from the LinkFactory (https://git.typo3.org/typo3/typo3/-/blob/main/typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php#L186-L187).


Files

screen.png (123 KB) screen.png debug output V12.4.7 PageViewHelper line 187 and 190 Helmut Strasser, 2023-10-03 07:34
Actions #1

Updated by Helmut Strasser 7 months ago

Tried to reproduce this on v11, v12 and v13. Works like expected.
target="home" is rendered as it is, as well as all other allowed values like _blank, _self etc.

Actions #2

Updated by Daniel Corn 7 months ago

I went down the rabbit hole :D

The problem seems to occur if `config.intTarget` is set (https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Setup/Config/Index.html#inttarget).

Actions #3

Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81312

Actions #4

Updated by Gerrit Code Review 7 months ago

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81313

Actions #5

Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81312

Actions #6

Updated by Helmut Strasser 7 months ago

Sorry for the mess. Created new commit instead of amending the old one.
https://review.typo3.org/c/Packages/TYPO3.CMS/+/81313 has been abandoned.

Actions #7

Updated by Gerrit Code Review 7 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81312

Actions #8

Updated by Gerrit Code Review 7 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81312

Actions #9

Updated by Gerrit Code Review 7 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81312

Actions #10

Updated by Gerrit Code Review 7 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81312

Actions #11

Updated by Gerrit Code Review 7 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81312

Actions #12

Updated by Gerrit Code Review 7 months ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81312

Actions #13

Updated by Gerrit Code Review 7 months ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81312

Actions #14

Updated by Gerrit Code Review 7 months ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81312

Actions #15

Updated by Gerrit Code Review 7 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81359

Actions #16

Updated by Helmut Strasser 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF