Project

General

Profile

Actions

Bug #101443

closed

Exception 'Undefined array key "pid"' after moving content in a workspace

Added by Ernesto Baschny 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2023-07-25
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Preconditions:

  • Any TYPO3 v11 (or later) installation
  • PHP 8.x
  • Workspaces extension enabled
  • no further extensions or configuration required

How to reproduce:

  • Create a Workspace
  • Create a page
  • Add two content elements (in LIVE mode)
  • Switch to the workspace
  • Drag & drop the first element after the second element - page will be marked as "modified" in the page tree
  • Try to add a new content element between or after these elements

You get this exception:

PHP Warning: Undefined array key "pid" in /app/packages/typo3/typo3/sysext/backend/Classes/Utility/BackendUtility.php line 3445

Background

This bug was introduced with https://review.typo3.org/c/Packages/TYPO3.CMS/+/65797

A potential workaround is to add the "pid" field to the list of `BackendUtilities::getCommonSelectFields` (see attached patch, which we will deploy in production to our customer to get around the problem for now). But maybe this is just hiding the real "problem". The @todos in `BackendUtilities::workspaceOL` give me a vibe that something could be fishy around here.


Files


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #92497: Remove move placeholdersClosedBenni Mack2020-10-07

Actions
Related to TYPO3 Core - Bug #98181: Undefined in array key in workspaceOL methodResolved2022-08-19

Actions
Actions #1

Updated by Ernesto Baschny 9 months ago

  • Related to Task #92497: Remove move placeholders added
Actions #2

Updated by Ernesto Baschny 9 months ago

The mentioned patch attached now.

@Benni Mack I mention you, because you are the original author of the breaking change. Maybe you have some idea?

Actions #3

Updated by Benni Mack 9 months ago

Ernesto Baschny wrote in #note-2:

The mentioned patch attached now.

@Benni Mack I mention you, because you are the original author of the breaking change. Maybe you have some idea?

See https://review.typo3.org/c/Packages/TYPO3.CMS/+/80042 and 98181 - problem is solved when you update.

Actions #4

Updated by Benni Mack 9 months ago

  • Related to Bug #98181: Undefined in array key in workspaceOL method added
Actions #5

Updated by Ernesto Baschny 9 months ago

  • Status changed from New to Closed

Amazing, hadn't seen it before. Also crazy that Georg made a patch that looks exactly the same as me one year ago and it was merged and released just last week.

Thanks @Benni Mack and @Georg Ringer!

Actions

Also available in: Atom PDF