Project

General

Profile

Actions

Task #101464

closed

Reactivate usage of constructable stylesheets for icon element

Added by Benjamin Franzke 9 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Category:
-
Start date:
2023-07-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

With #100270 stylesheets in icon elements have been inlined
instead of using lit's own style wrapper that uses constructable
stylesheets if available.
Inline stylesheets need to be parsed over and over again, whenever
a web component is used multiple times.
The icon element is supposed to be used very often, which is why this
matters. Constructable stylesheets are cached and therefore do only
need to be parsed once, regardless how often a web component is used.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #100270: Streamline icon elementsClosed2023-03-23

Actions
Related to TYPO3 Core - Bug #101747: Web Components with CSS in shadowRoot are not usable in cross frame boundariesRejectedBenjamin Franzke2023-08-24

Actions
Actions #1

Updated by Benjamin Franzke 9 months ago

Actions #2

Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80192

Actions #3

Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80192

Actions #4

Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80192

Actions #5

Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80192

Actions #6

Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80212

Actions #7

Updated by Anonymous 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benjamin Franzke 8 months ago

  • Related to Bug #101747: Web Components with CSS in shadowRoot are not usable in cross frame boundaries added
Actions #9

Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF