Project

General

Profile

Actions
Copy link

Task #101673

closed

Explain how to replace existing linktypes in linkvalidator

Added by Sybille Peters 9 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
Sybille Peters
Category:
Linkvalidator
Target version:
-
Start date:
2023-08-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Previously, it used to be possible to replace and override an existing linktype without XCLASS.

With the change https://review.typo3.org/c/Packages/TYPO3.CMS/+/73568, the linktypes are automatically registered so it is not possible to deactivate or replace one of them directly. (It is still possible with XCLASS).

- check what is current best practice for doing this
- document it

Currently we have an example for creating a new custom type: https://docs.typo3.org/c/typo3/cms-linkvalidator/main/en-us/Development/LinkTypeImplementation.html

AFAIK the identifier of the linktype must correspond to the link type returned by the link parsers, so we can't just use a different identifier.

A different identifier must be used for the new custom class.

Since we recommend to "override the ExternalLinktype class" as one possibility in Known problems, this should also be documented.

Actions
Copy link
 #1

Updated by Sybille Peters 3 months ago

  • Description updated (diff)
  • Assignee set to Sybille Peters
Actions
Copy link
 #2

Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82894

Actions
Copy link
 #3

Updated by Sybille Peters 3 months ago

  • Description updated (diff)
  • Status changed from Under Review to New
Actions
Copy link
 #4

Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82894

Actions
Copy link
 #5

Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82894

Actions
Copy link
 #6

Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82894

Actions
Copy link
 #7

Updated by Gerrit Code Review 2 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82894

Actions
Copy link
 #8

Updated by Gerrit Code Review 2 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82894

Actions
Copy link
 #9

Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82849

Actions
Copy link
 #10

Updated by Sybille Peters 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF