Project

General

Profile

Actions

Bug #101709

closed

TypoLink forceAbsoluteUrl is not working anymore on processed image resources from static files

Added by Oliver Hader 8 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2023-08-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

page = page
page {
    meta {
        twitter:image {
            attribute = property
            cObject = TEXT
            cObject {
                typolink.parameter.cObject = IMG_RESOURCE
                typolink.parameter.cObject {
                    file = EXT:site/Resources/Public/Images/indie-logo-inverted.png
                    file.width = 1200m
                    file.height = 628m
                }
                typolink.forceAbsoluteUrl = 1
                typolink.returnLast = url
            }
        }
    }
}
  • the generated result of IMG_RESOURCE is something like /typo3temp/assets/_processed_/8/e/csm_indie-logo-inverted_f323361c00.png
  • LegacyLinkNotationConverter considers this to be handled by LinkService::TYPE_URL, since it was generated in the root-file-storage (storage-uid=0)
  • ExternalUrlLinkBuilder (used for LinkService::TYPE_URL) does not consider forceAbsoluteUrl

This results in the incorrect output of having:

<meta name="twitter:image" content="/typo3temp/assets/_processed_/8/e/csm_indie-logo-inverted_f323361c00.png" />

But, it actually should contain the domain as well:

<meta name="twitter:image" content="https://indiemusik-festival.de/typo3temp/assets/_processed_/8/e/csm_indie-logo-inverted_f323361c00.png" />

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #101083: Relative path creation not posible. Link type "unknown" is not allowed for the field "target" of the table "sys_redirect"Resolved2023-06-15

Actions
Actions #1

Updated by Oliver Hader 8 months ago

  • Related to Bug #101083: Relative path creation not posible. Link type "unknown" is not allowed for the field "target" of the table "sys_redirect" added
Actions #3

Updated by Oliver Hader 8 months ago

  • Description updated (diff)
  • Is Regression set to Yes
Actions #4

Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80597

Actions #5

Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80597

Actions #6

Updated by Gerrit Code Review 8 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80597

Actions #7

Updated by Gerrit Code Review 8 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80663

Actions #8

Updated by Oliver Hader 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF