Project

General

Profile

Actions

Task #101716

closed

Improve changelog Breaking-100229-ConvertJSConfirmationToBitSet.html

Added by Sybille Peters 8 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Category:
Documentation
Target version:
-
Start date:
2023-08-20
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-100229-ConvertJSConfirmationToBitSet.html

The improvements are pretty minimal and not strictly necessary (except for the formatting). Normally, I would not start a patch for this, but there is already a patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/80599 where I first intended to make more changes (in particular the formatting of the bullet lists), but was deemed as too much.

1. bullet lists should have a newline before and after, otherwise they will not be rendered correctly, see https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-100229-ConvertJSConfirmationToBitSet.html#impact: matches, setValue and isValid is a list

2. \TYPO3\CMS\Core\Type\Bitmask\JSConfirmation::method should be \TYPO3\CMS\Core\Type\Bitmask\JSConfirmation?

3. "calling public methods methods" should be "calling public methods"

4. The part for BackendUserAuthentication->jsConfirmation() in "Affected installations" could be rephrased for "affected installations"


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #101714: Fix syntax error in changelogClosed2023-08-19

Actions
Actions #1

Updated by Sybille Peters 8 months ago

  • Related to Task #101714: Fix syntax error in changelog added
Actions #2

Updated by Sybille Peters 8 months ago

  • Description updated (diff)
Actions #3

Updated by Sybille Peters 8 months ago

  • Description updated (diff)
Actions #4

Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80601

Actions #5

Updated by Sybille Peters 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF