Project

General

Profile

Actions
Copy link

Bug #101893

closed

Page TSConfig crashes browser with T3Editor extension enabled

Added by Riccardo De Contardi 8 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
t3editor
Target version:
-
Start date:
2023-09-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I don't know if it is a problem of my installation

Steps to reproduce on latest main (13.0.0-dev) on a ddev installation

1) Disable t3editor
2) Edit Home page > tab resorces > field TSConfig > write more than 5 lines (it seems it is not important if it's actual code or just comments)
3) Save and close
4) Enable t3editor
5) Edit Home page > tab resorces

Result

the TSConfig field does not load, it just shows the spinning icon for a while, until the whole browser tab becomes unresponsive and the browser suggest you to kill it.

I tested with both Chrome and Firefox

As far as I have seen it seems that everything inside the the field with the T3Editor enabled is fine until you reach the 5th line of code , then it crashes

Files

Screenshot 2023-09-12 alle 12.25.46.png (496 KB) Screenshot 2023-09-12 alle 12.25.46.png Riccardo De Contardi, 2023-09-12 10:27

Related issues 2 (0 open — 2 closed)

Has duplicate TYPO3 Core - Bug #102047: Backend crashes as soon as "/*" is entered in t3editorClosed2023-09-27

Actions
Has duplicate TYPO3 Core - Bug #102484: Browser Crash after copy a @import 'EXT:myproject/Configuration/TypoScript/*.typoscript' Codeline into the Typoscript Editor Closed2023-11-23

Actions
Actions
Copy link
 #1

Updated by Georg Ringer 8 months ago

can't reproduce, are there any ajax responses with error?

Actions
Copy link
 #2

Updated by Georg Ringer 8 months ago

  • Status changed from New to Needs Feedback
Actions
Copy link
 #3

Updated by Riccardo De Contardi 8 months ago

Hello Georg,

I noticed that my note about the "5th line of code" was misleading! Actually I have been able to add more lines... it looks like that the crash happens when I type (no matter at what line) :

/*

i.e. the beginning of a comment.

The same issue affects also other fields with t3editor like the TS Setup field

Sorry but I don't see any ajax response when the error starts to kick in. But I tried the following:

1) I Disabled t3editor
2) I put in the tsconfig field some lines like:

/*
RTE.default.buttons.link.pageIdSelector.enabled = 1
RTE.default.buttons.link.queryParametersSelector.enabled = 1
RTE.default.buttons.link.relAttribute.enabled = 1

RTE.default.buttons.link.targetSelector.disabled = 0
RTE.default.buttons.link.popupSelector.disabled = 0
RTE.default.buttons.link.options.removeItems = folder
*/

3) Saved it and clicked on "General" Tab
4) Re-enabled t3editor
5) Open Chrome console > tab network > filter by Fetch/XHR
6) Open the page with the field filled > edit
7) Click on "Resources"
Result: 2 requests remain in pending (see attached screenshot)

Actions
Copy link
 #4

Updated by Riccardo De Contardi 7 months ago

  • Has duplicate Bug #102047: Backend crashes as soon as "/*" is entered in t3editor added
Actions
Copy link
 #5

Updated by Riccardo De Contardi 7 months ago

  • Status changed from Needs Feedback to New
  • TYPO3 Version changed from 13 to 12

As reported by Marco Kuprat, this issue also affects TYPO3 12.4.6

- Adjust TYPO3 version accordingly.
- Add here the info from #102047 :

Environment:
TYPO3 12.4.6
t3editor activated

As soon as you enter /* in t3editor, the backend crashes (tested in Firefox, Chrome and Opera on a Windows 10 machine); Firefox reports some javascript slowing down the page.
You have to reload the backend in order to get it working again.

The bug did not exist in TYPO3 12.4.5, it was introduced in TYPO3 12.4.6.

Actions
Copy link
 #6

Updated by Garvin Hicking 5 months ago

Reproducible in v13/main for me

Actions
Copy link
 #7

Updated by Garvin Hicking 5 months ago

  • Has duplicate Bug #102484: Browser Crash after copy a @import 'EXT:myproject/Configuration/TypoScript/*.typoscript' Codeline into the Typoscript Editor added
Actions
Copy link
 #8

Updated by Garvin Hicking 5 months ago

Addendum: It not only affects comments, but also valid "normal" lines:

@import 'EXT:myproject/Configuration/TypoScript/*.typoscript'

This would need to not be parsed as a comment but valid wildcard syntax within a string.

Actions
Copy link
 #9

Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82038

Actions
Copy link
 #10

Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82038

Actions
Copy link
 #11

Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82038

Actions
Copy link
 #12

Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82046

Actions
Copy link
 #13

Updated by Garvin Hicking 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF