Project

General

Profile

Actions

Bug #102063

closed

Undefined array key "editlock" in DatabaseRecordList

Added by Guido Schmechel 7 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2023-09-28
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.1
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Core: Error handler (BE): PHP Warning: Undefined array key "editlock" in /typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php line 2304

https://github.com/TYPO3/typo3/blob/11.5/typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php#L2304

It should still be checked whether $row also exists with this key

elseif (isset($GLOBALS['TCA'][$table]['ctrl']['editlock']) && $row[$GLOBALS['TCA'][$table]['ctrl']['editlock']]) {

->

elseif (isset($GLOBALS['TCA'][$table]['ctrl']['editlock']) && isset($row[$GLOBALS['TCA'][$table]['ctrl']['editlock']]) && $row[$GLOBALS['TCA'][$table]['ctrl']['editlock']]) {

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #98459: Undefined array key "editlock" in DatabaseRecordListClosedMarkus Klein2022-09-28

Actions
Actions #1

Updated by Guido Schmechel 7 months ago

  • Related to Bug #98459: Undefined array key "editlock" in DatabaseRecordList added
Actions #2

Updated by Markus Klein 7 months ago

So this means you have invalid TCA or a missing DB field, right?

If this is the case, I would say this is not a case that core must be able to cope with.

Actions #3

Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81301

Actions #4

Updated by Oliver Bartsch 7 months ago

Markus Klein wrote in #note-2:

So this means you have invalid TCA or a missing DB field, right?

If this is the case, I would say this is not a case that core must be able to cope with.

Generally with you. However adding some additional checks does IMO not hurt in this case.

Actions #5

Updated by Gerrit Code Review 7 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81284

Actions #6

Updated by Oliver Bartsch 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Gerrit Code Review 7 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81306

Actions #8

Updated by Oliver Bartsch 7 months ago

  • Status changed from Under Review to Resolved
Actions

Also available in: Atom PDF