baseUri is added on external links
|Priority:||Should have||Due date:|
|Assignee:||Sebastian Kurfuerst||% Done:||
|Target version:||Extbase 1.3|
I encountered a bug in
Tx_Extbase_MVC_Controller_AbstractController::addBaseUriIfNecessary. If I want to redirect to an external URI via
redirectToURI() the base URL is added by mistake.
In my opinion the method
addBaseUriIfNecessary does not behave as it should.
When is the baseUri needed? - It is needed when the uri is relative but at the moment it compares if the uri to redirect contains the base uri. Thus it is not possible to link to external URIs.
Solution: The method
addBaseUriIfNecessary only adds the baseUri if the $uri does not start with http:// or https://
The attached patch fixes this behaviour and provides the corresponding unit-test
[+BUGFIX] baseUri is added on external links
On a redirect to an external URI via redirectToURI(),
the base URL is added by mistake.
Thanks to Michael Feinbier for this fix!
Updated by Marc Bastian Heinrichs over 2 years ago
- Assignee set to Marc Bastian Heinrichs
- Target version set to Extbase 1.4
Updated by Mr. Hudson about 2 years ago
Patch set 1 of change I641d5bd0de7ede81bf9ed6568290d554f9580138 has been pushed to the review server.
It is available at http://review.typo3.org/2379
Updated by Sebastian Kurfuerst about 2 years ago
- Status changed from New to Resolved
- Assignee changed from Marc Bastian Heinrichs to Sebastian Kurfuerst
- % Done changed from 90 to 100
- Has patch set to No