Project

General

Profile

Actions
Copy link

Bug #103056

closed

The extension scanner does not report "Breaking: #96641 - TypoLink related hooks removed"

Added by Daniel Siepmann 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2024-02-06
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The change log entry can be found at: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Breaking-96641-TypoLinkRelatedHooksRemoved.html

I'd expect the scanner to report a strong match for those two occurences:

$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['typoLink_PostProc'][$extKey] = \Vendor\OurKey\LinkBuilding\CustomCssClassBasedOnType::class . '->process';

And:

    \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($GLOBALS['TYPO3_CONF_VARS'], [
        'SC_OPTIONS' => [
            'tslib/class.tslib_content.php' => [
                'typoLink_PostProc' => [
                    $extKey => \Vendor\OurKey\LinkBuilding\CustomCssClassBasedOnType::class . '->process',
                ],
            ],
        ],
    ]);

Neither is reported.

Actions
Copy link
 #1

Updated by Oliver Bartsch 3 months ago

  • Status changed from New to Needs Feedback

Hi Daniel,

these occurrences should be reported as "weak" match (like all array access matches). Where exactly did you define the mentioned hook registrations?

I just checked them in an ext_localconf.php and got a report, at least for the first registration. I assume the array merge construct is not supported by the extension scanner.

Best, Oli

Actions
Copy link
 #2

Updated by Daniel Siepmann 3 months ago

  • Status changed from Needs Feedback to Closed

I also had them within ext_localconf.php.

The first one was a trial to check whether that would work as I thought the merge might not work.
And indeed it is a weak match … I'd expect it to be a strong match, but I don't know how the scanner internals work. I'd thought it would be able to detect that it is the key in proper context. Why else wouldn't it find the array_merge approach?

But I'll close as this seems to be the expected behaviour and not a bug. Thanks for your fast response and explanation.

Actions
Copy link

Also available in: Atom PDF