Task #10316

Check CldrModelCollection::getRawArray() for correct behaviour

Added by Karsten Dambekalns over 2 years ago. Updated over 2 years ago.

Status:Resolved Start date:
Priority:Should have Due date:
Assignee:Karol Gusak % Done:

100%
Category:I18n
Target version:TYPO3 Flow Base Distribution - 1.0 alpha 13
Sprint: Has patch:
PHP Version: Complexity:
Votes: 0

Description

The CldrModelCollection::getRawArray() method is supposed to always return an array, but sometimes the given path leads to a literal value. http://review.typo3.org/175 adds some fix for this to avoid an error in those cases, but this needs to be check in detail.

Associated revisions

Revision 07ebe763
Added by Karol Gusak over 2 years ago

[~TASK] FLOW3 (I18n): Make CldrModel::getRawArray() always return array or FALSE

The method getRawArray() now returns array (or FALSE on failure).
Additionally, a new method called getRawData() returns array or string
(if the path points to a leaf).

Resolves: #10316
Change-Id: I78e7862039b92f8b5f945ba3a4c55659e3af37c5

History

#1
Updated by Karsten Dambekalns over 2 years ago

  • Status changed from New to Needs Feedback
  • Assignee set to Karol Gusak

Karol, could you check this, please?

#2
Updated by Karol Gusak over 2 years ago

  • Status changed from Needs Feedback to Under Review

Sure, I will check this and other changes from the review soon (I glimpsed on them but I have some doubts about the models).

#3
Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Under Review to Accepted

Great, thanks Karol! If you need help with Gerrit (for the patch set review), let me know.

#4
Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Accepted to Under Review

#5
Updated by Karol Gusak over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF