Feature #10535
Improve error messages
| Status: | Closed | Start date: | 2010-10-29 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Andy Grunwald | % Done: | 100% |
|
| Category: | Stuff | Spent time: | - | |
| Target version: | 0.0.4 | |||
| Branch: | v4 | Tags: | ||
| Votes: | 0 |
Description
It would be better to get explaining error message instead of only a notice that $_GET is not allowed.
Associated revisions
[FEATURE] Improve error messages in TYPO3.NamingConventions.ValidVariableName
In TYPO3 direct access to $_GET and / or $_POST is not allowed.
The valid variable name sniffs detects such variables, but the error
message is not very meanful. To improve the error message,
we output another message if the variable is $_GET / $_POST.
The unit tests was extended with this new usecases, too.
Change-Id: I83c297c20d50be302a184f4c663df17408de0043
Fixes: #10535
Releases: 0.0.4
History
Updated by Stefano Kowalke over 2 years ago
We could provide a link in the message which leads to a dedicated forge page where we explain the error and give hints for the better way.
Updated by Stefano Kowalke over 2 years ago
- Category set to Stuff
- Status changed from New to Needs Feedback
- Assignee set to Andy Grunwald
- Target version set to 0.0.4
Which error messages do you mean?
Updated by Andy Grunwald over 2 years ago
- Tracker changed from Bug to Feature
Updated by Andy Grunwald over 2 years ago
This ticket was moved from bug to feature, because this is no bug.
This is only an improvement.
The idea is the following:
$_GET is a variable who`s forbidden. If, for example, $_GET is used, a error message like "$_GET is forbidden, please use t3lib_div::_GET or t3lib_div::_GP instead" would be more usefull.
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10862
Updated by Andy Grunwald about 1 year ago
- Status changed from Needs Feedback to Under Review
Okay, here we go.
I`ve created a new message, if the variablename is $_GET / $_POST.
The change is i gerrit
Updated by Stefano Kowalke about 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Branch set to v4
Updated by Stefano Kowalke 9 months ago
- Status changed from Resolved to Closed