Bug #10753
[patch] incompatibility with displaycontroller_advanced, filter and phpdisplay
| Status: | Closed | Start date: | 2010-11-12 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Francois Suter | % Done: | 100% |
|
| Category: | Data Structure | |||
| Target version: | 1.2.0 | |||
| Votes: | 0 |
Description
When using the following set of components:
- Display Controller Advanced
- DataQuery
- DataFilter
- PHPdisplay
There is an issue with $filter variable available in PHPdisplay. This variable contains the last filter processed and not all filters from all dataqueries. This inconsistency make it hard (impossible) to work with filter data within our php file.
The suggested solution is to include the filter data within the datastructure of the dataquery. This way records and filter are always kept together. I believe it is more consistent (datastructure already contains metadata such as totalCount, headers, etc.), easier to work with and easier to understand.
The attached patch implement this.
If this patch is accepted we probably should remove the $filter variable in PHPdisplay as it would be unnecessary and very confusing.
Related issues
| related to Google Query Data Provider - Feature #13971: Store filter information inside the data structure | Closed | 2011-03-22 | ||
| precedes PHP-based Data Display - Bug #10757: [patch] remove $filter variable | New | 2010-11-13 | 2010-11-13 |
Associated revisions
Fixed issue: #10753: Inconsistency: tab is not supported in the TS editor
Added storage of filter information inside data structure, resolves #10753
Regenerated the PDF version of the manual
Added storage of filter information inside data structure, resolves #10753
Regenerated the PDF version of the manual
History
Updated by Francois Suter over 2 years ago
- Target version set to 1.2.0
No time to handle this now, will include it in the next release.
Updated by Francois Suter about 2 years ago
- Status changed from New to Accepted
- Assignee set to Francois Suter
Updated by Francois Suter about 2 years ago
- % Done changed from 0 to 100
Updated by Francois Suter about 2 years ago
- Status changed from Accepted to Resolved
Updated by Francois Suter about 2 years ago
- Status changed from Resolved to Closed