CoreCommunity ExtensionsIncubatorDistributionsTYPO3 4.5 ProjectsTYPO3 4.6 ProjectsTYPO3 4.7 ProjectsTYPO3 6.0 ProjectsTYPO3 6.1 ProjectsTYPO3 6.2 Projects (+)

Bug #11226

Post-subscriber will not get eMail if new comment was posted and approved

Added by Juergen Kussmann over 2 years ago. Updated 12 months ago.

Status:Resolved Start date:2010-12-02
Priority:Should have Due date:
Assignee:Felix Nagel % Done:

90%
Category:Bug
Target version:-
Votes: 0

Description

In ext_tables.sql you define this table:

#
  1. Table structure for table 'tx_t3blog_com_nl' #
    CREATE TABLE tx_t3blog_com_nl (
    uid int(11) NOT NULL auto_increment,
    pid int(11) DEFAULT '0' NOT NULL,
    tstamp int(11) DEFAULT '0' NOT NULL,
    crdate int(11) DEFAULT '0' NOT NULL,
    deleted tinyint(4) DEFAULT '0' NOT NULL,
    email tinytext NOT NULL,
    name tinytext NOT NULL,
    post_uid int(11) DEFAULT '0' NOT NULL,
    lastsent int(11) DEFAULT '0' NOT NULL,
    code tinytext NOT NULL,

    PRIMARY KEY (uid),
    KEY parent (pid)
    );

In mod3/index.php you create this SQL-query:
SELECT * FROM tx_t3blog_com_nl WHERE post_uid=24 AND hidden=0 AND deleted=0
The bug is, that the table tx_t3blog_com_nl doesn’t have the column hidden.
The result oft that bug is, that no subscriber will ever get an eMail (if editor approves a comment) AND the sys_log-table in TYPO3 will be spamed with PHP-warnings (that was the reason as i found that bug).

Please fix the bug in mod3/index.php near the line 418. You can also search for $GLOBALS['TYPO3_DB']->exec_SELECTgetRows($field_send, $table_send, $where_send); to find the code-position. At this time, i use the tag 1_0_0 of your t3blog-Extension (from https://svn.typo3.org/TYPO3v4/Extensions/t3blog/tags/1_0_0). It would be cool, if you could also fix the bug in that tag :-)

Related issues

related to T3BLOG - Bug #34655: Send subscriber emails when comment is approved as non SPAM Needs Feedback 2012-03-07

History

#1
Updated by Felix Nagel over 2 years ago

Please check this issue: http://forge.typo3.org/issues/9071

You're right. Their should be a notice in the doc that subscribers email does not work if new comments needs to be approved. Perhaps you found a solution to issue 9071 with this post? Please give feedback as this is a major bug!

#2
Updated by Juergen Kussmann over 2 years ago

Please give feedback as this is a major bug!
The solution for this bug is quit simple: Just create the db-field 'deleted' in table 'tx_t3blog_com_nl'. That should be all.

#3
Updated by Christoph Hermann about 2 years ago

This fixes the problem:
ALTER TABLE tx_t3blog_com_nl ADD hidden tinyint(4) DEFAULT '0' NOT NULL;

Line 429 in mod3/index.php is also wrong, if the server url contains a subdir:
$unsubscribe = '<http://'.$_SERVER['SERVER_NAME'].'/index.php?id='.$this->id.'&tx_t3blog_pi1[blogList][showUid]='.$postuid.'&tx_t3blog_pi1[blogList][unsubscribe]=1&tx_t3blog_pi1[blogList][code]='.$value['code'].'&no_cache=1>' ."\n";

this url needs to be constructed using typoLink_URL

#4
Updated by Felix Nagel about 1 year ago

  • Status changed from New to Accepted
  • Assignee set to Felix Nagel
  • Target version deleted (1.1.1)
  • % Done changed from 0 to 90

This problem is only relevant if t3blog is configured approved = 0.

This is still a problem in current trunk and should be fixed. Simply add hidden column to the sql file:

hidden tinyint(4) DEFAULT '0' NOT NULL,

#5
Updated by Felix Nagel 12 months ago

  • Status changed from Accepted to Resolved

Already fixed in current trunk, see: r59052

Also available in: Atom PDF