PHP_CodeSniffer

Currently, variable names like $_SERVER, $TYPO3_CONF_VARS etc. are being complained about.

Slightly related, variables that are not lower camel case are not marked so if they also contain underscores.

Here is a revised version of ValidFunctionNameSniff.php:

    protected function processVariableNameCheck(PHP_CodeSniffer_File $phpcsFile, $stackPtr, $scope = '') {
        $tokens = $phpcsFile->getTokens();
        $variableName = ltrim($tokens[$stackPtr]['content'], '$');
        $variableNamesWhitelistInbuilt = array('_SERVER', '_COOKIE', '_REQUEST', '_GET', '_POST', '_FILES', '_SESSION', '_ENV', 'GLOBALS');
        $variableNamesWhitelistTypo3 = array('TCA', '_EXTKEY', 'EM_CONF', 'TYPO3_CONF_VARS');
        $variableNamesWhitelist = array_merge($variableNamesWhitelistInbuilt, $variableNamesWhitelistTypo3);

        if (in_array($variableName, $variableNamesWhitelist)) {
            return;
        } else {
            $hasUnderscores = stripos($variableName, '_');
            $isLowerCamelCase = preg_match_all('/(\b[a-z]{1,})\b|(\b[a-z]{1,})([A-Z]{1}[a-z]{1,}){1,}\b/', $variableName, $matches);
            if ($hasUnderscores !== FALSE) {
                $error = 'Underscores are not allowed in the ' . $scope . 'variablename "$' . $variableName . '"; ';
                $error.= 'use lowerCamelCase for identifier instead';
                $phpcsFile->addError($error, $stackPtr);
            }
            if ($isLowerCamelCase === 0) {
                $error = ucfirst($scope) . 'variablename "$' . $variableName . '" must use lowerCamelCase;';
                $phpcsFile->addError($error, $stackPtr);
            }
        }