CoreCommunity ExtensionsIncubatorDistributionsTYPO3 4.5 ProjectsTYPO3 4.6 ProjectsTYPO3 4.7 ProjectsTYPO3 6.0 ProjectsTYPO3 6.1 ProjectsTYPO3 6.2 Projects (+)

Feature #12668

Workspace preview

Added by Henrik Jahn over 2 years ago. Updated 4 months ago.

Status:Resolved Start date:2011-01-31
Priority:Should have Due date:
Assignee:- % Done:

100%

Category:Backend
Target version:2.0.0
TYPO3 Version:4.7 Has patch:Yes
PHP Version: Complexity:
Votes: 1 (View)

Associated revisions

Revision 629d36f3
Added by Georg Ringer 4 months ago

[TASK] Allow preview of single news in workspace

Remove a not needed restriction, so that the preview
of a record is also possible if the user is within a
workspace

Change-Id: I6448e913aaef28f54c5036047598c46e27e1e6ef
Resolves: #12668
Reviewed-on: https://review.typo3.org/17408
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

History

Updated by Georg Ringer over 2 years ago

  • Status changed from New to Needs Feedback

what exactly do you mean? A fetch of the correct records is a task of extbase as news2 doesn't create any queries on itself. news2 doesn't do any overlay or so on its own

Updated by Nikolas Hagelstein about 2 years ago

  • Status changed from Needs Feedback to Rejected

Should work out of the box, if not please reopen.

Updated by Felix Nagel 11 months ago

  • Category set to Backend
  • Status changed from Rejected to New
  • Patch is reviewed set to No
  • Has patch set to Yes
  • TYPO3 Version set to 4.7

Ive tested workspace in TYPO3 4.7.1 with latest trunk.

Here are my results:
  • Save and preview wont work: a 404 page is displayed, although when reloading the normal preview page (opened before in BE) it seems to work correct
  • Versioning itself seems to work, at least a little as the WS module shows changes and publishing workspace works as expected

Afaics the problem is in Tcemain.php hook as its does not provide a link when "non live workspace" is used:

&& !$GLOBALS['BE_USER']->workspace

Removing this condition seems to fix the general preview problem. What was its original purpose?

After removing that condition preview works as expected but with problems:
  • using list and detail view together on one page we wont work, list view is displayed instead of detail view
  • "live workspace" preview wont work for localized news but "none live workspace" version preview works
  • using different pages for list and detail fails completely: "#1176558158: An argument "news" does not exist for this request. Tx_Extbase_MVC_Exception_NoSuchArgument thrown in file typo3\sysext\extbase\Classes\MVC\Request.php in line 398."

Updated by Georg Ringer 4 months ago

  • Status changed from New to Resolved
  • Target version set to 2.0.0
  • % Done changed from 0 to 100

restriction removed with https://review.typo3.org/#/c/17408/

however the rest is problem of the core/extbase, no change needed within the extension itself. if problem is still in 6.0, open an issue in core project.

Also available in: Atom PDF