Bug #13500
Task #3754: Usability
Select "select an extension" if an invalid extension has been selected in the extension drop-down
| Status: | New | Start date: | 2011-03-01 | |
|---|---|---|---|---|
| Priority: | Could have | Due date: | ||
| Assignee: | Nicole Cordes | % Done: | 0% |
|
| Category: | - | |||
| Target version: | Cleanup | |||
| PHP Version: | ||||
| Votes: | 0 |
Related issues
| blocked by PHPUnit - Task #36106: Move creating the test drop-down to a ViewHelper | New | 2012-04-15 |
History
Updated by Oliver Klee about 2 years ago
- Parent task set to #3754
Updated by Nicole Cordes about 1 year ago
- Assignee set to Nicole Cordes
Updated by Oliver Klee about 1 year ago
This also includes making the "Select an extension" option selectable.
I'd also prefer the "select an extension" label to go away. Instead, we should have an empty option at the top of the selector.
Updated by Nicole Cordes about 1 year ago
I've got the feeling this also means to not preselect the phpunit extension. Otherwise the select option can't be chosen. Do you agree with that?
Updated by Oliver Klee about 1 year ago
Nicole Cordes wrote:
I've got the feeling this also means to not preselect the phpunit extension. Otherwise the select option can't be chosen. Do you agree with that?
Yes, I fully agree.
Updated by Nicole Cordes about 1 year ago
- File 20120509_1038_patch_13500.diff added
Added a new function has() to an interface (and also unit tests for it) and removed the fix phpunit selection.
Updated by Oliver Klee about 1 year ago
Why not use the existing method hasString() instead of adding a has() method?
Updated by Nicole Cordes about 1 year ago
Because it returns false for empty values.
Updated by Oliver Klee about 1 year ago
Is there a use case where we need to differentiate between "no selection" and "empty selection"?
BTW, I'd like us to finish the blocking bug first.
Updated by Nicole Cordes about 1 year ago
I think we have to care about 4 different cases:
1) Select right extension -> reselect it on submit
2) Select (submit) false extension -> select "select extension" option
3) Submit empty value -> select "select extension" option
4) Submit without value (another form was submitted) -> select last stored extension
This is why we need the difference between no value and empty value.
Updated by Oliver Klee 12 months ago
Nicole Cordes wrote:
I think we have to care about 4 different cases:
1) Select right extension -> reselect it on submit 2) Select (submit) false extension -> select "select extension" option 3) Submit empty value -> select "select extension" option 4) Submit without value (another form was submitted) -> select last stored extension
This is why we need the difference between no value and empty value.
Actually, we the action is part of the corresponding form. So we know which button has been used.
In addition, we should disable the submit button when nothing is selected (#37769). So 4) then will not happen.