Bug #13590

Firefox can not open diff view of a determined change

Added by Sonja Schubert about 2 years ago. Updated about 2 years ago.

Status:Closed Start date:2011-03-03
Priority:Should have Due date:
Assignee:Karsten Dambekalns % Done:

0%
Category:Gerrit
Target version:-
Votes: 0

Description

When I click on the link "side-by-side" next to the tslib change it takes some seconds and then the browser tries to stop the javascript with a popup. See screenshot.

The problem occurs only with Firefox 3.5.7 and change 1003 on review.typo3.org. In Safari or with another change it works well and the diff view is opened.

Bildschirmfoto_2011-03-03_um_17.52.09.png (55.3 kB) Sonja Schubert, 2011-03-03 18:00

History

#1
Updated by Karsten Dambekalns about 2 years ago

  • Category set to Gerrit
  • Status changed from New to Closed
  • Assignee set to Karsten Dambekalns

Just click ok. :) It should work a few more seconds and then display fine, no?

The diff is calculated client side (at least the view of the diff), and we all know tslib is a monster. Just the "(... skipping 3820 common lines ...)" above the changed hunk is an indication for this.

Also available in: Atom PDF