Task #13737
Make use of Tx_Extbase_Reflection_ObjectAccess instead of self written code
| Status: | Resolved | Start date: | 2011-03-10 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Nikolas Hagelstein | % Done: | 100% |
|
| Category: | Core | |||
| Target version: | - | |||
| TYPO3 Version: | Has patch: | |||
| PHP Version: | Complexity: | |||
| Votes: | 0 |
Description
Hey folks,
I just had a very quick look on parts of your code and noticed that you don't make use of Tx_Extbase_Reflection_ObjectAccess methods to get and set properties on dynamically processed objects, like you do in the "overwriteDemandObject" method of the NewsController. It might be better to use Tx_Extbase_Reflection_ObjectAccess here instead of the way it's currently done. It's just a suggestion.
Associated revisions
[-TASK]: Use reflection method to set demand properties. Thanks to Franz Koch for pointing this out. Resolves #13737.
[-TASK]: Use reflection method to set demand properties. Thanks to Franz Koch for pointing this out. Resolves #13737.
git-svn-id: https://svn.typo3.org/TYPO3v4/Extensions/news2/trunk@45006 735d13b6-9817-0410-8766-e36946ffe9aa
History
Updated by Georg Ringer about 2 years ago
- Assignee set to Nikolas Hagelstein
Updated by Nikolas Hagelstein about 2 years ago
- Status changed from New to Accepted
Hi,
thanks for pointing out. Your are right:)
I was just to lazy to digg trough the reflection service and look for the appropriate method.
Updated by Nikolas Hagelstein about 2 years ago
- Status changed from Accepted to Resolved
- % Done changed from 0 to 100
Applied in changeset r45006.