Bug #17550
closed
Object copied in t3lib_div::makeInstance
0%
Description
t3lib_div::makeInstance call itslef recursively to handle ux_* classes, but the recursive call is not really well done, because it copy the instanciated object (instead of giving a reference)
Of course the problem does not occurs on PHP5, but I think it can be a good thing to fix it by making makeInstance more "sexy" (by using the makeInstanceClassname).
Because of this, the tslib_patcher extension can not work under php4, because an object reference is corrupted by the object copy.
(issue imported from #M6193)
Files
Updated by Jean-David Gadina over 16 years ago
This is indeed a problem with PHP 4... But as the next version of T3 will only run on PHP5, I don't think there is a need to fix it : )
For info, I fixed the problem in tslib_patcher...
Updated by Popy no-lastname-given over 16 years ago
Yes, but the code is still ugly :)
Updated by Jean-David Gadina over 16 years ago
Just look at the original one... :P
.<
Updated by Ingo Renner over 16 years ago
The next release of TYPO3 (4.2) will require have a minimum requirement of php 5.2. We can't add this patch to the previous development branches...
Updated by Michael Stucki over 16 years ago
IMHO this is no bugfix, but a cleanup. And it also looks better with PHP5 :-)
- michael
Updated by Popy no-lastname-given over 16 years ago
@ Michael Stucki : I love you :D
Updated by Ingo Renner over 16 years ago
hmm, true. but I don't know whether this would break things or whether we can cahnge it in current branches at all
Updated by Michael Stucki over 16 years ago
As I said: It's not a bugfix, therefore it's not needed in stable branches. Pretty easy, let's just fix it in Trunk...