Bug #17947

TCE: error message if no label has been set in TCA

Added by Franz Holzinger over 5 years ago. Updated 8 months ago.

Status:Closed Start date:2007-12-22
Priority:Should have Due date:
Assignee:- % Done:

100%
Category:Backend API
Target version:-
TYPO3 Version:4.2 Complexity:easy
PHP Version:5.1
Votes: 0

Description

A wrong SQL is generated, if you did not set the ctrl label field for a table.

SELECT tx_mytable.uid,tx_mytable.
FROM tx_mytable,pages
WHERE
pages.uid=tx_mytable.pid
AND pages.deleted=0 AND 1=1

This happens when you open a record of this table in the list module.

(issue imported from #M7039)

notcalabel.diff (606 Bytes) Administrator Admin, 2007-12-22 13:59

Related issues

related to Core - Feature #34039: Unit test for t3lib_befunc::getCommonSelectFields Resolved 2012-02-17

Associated revisions

Revision c3360a8c
Added by Philipp Gampe over 1 year ago

[FEATURE] Unit test for t3lib_befunc::getCommonSelectFields

Change-Id: I61fa3a31ccdb141c77fb96b0714a2c412380ed0d
Resolves: #34039
Related: #17947
Releases: 4.7
Reviewed-on: http://review.typo3.org/9071
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision d0a1a255
Added by Mario Rimann over 1 year ago

[BUGFIX] TCE: error message if no label has been set in TCA

Avoids an invalid SQL query if no label column is specified by the
TCA for a certain table.

Change-Id: I90211a6bbcbd00a8f0fda25c68c99a1aba3f8a1a
Fixes: #17947
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6992
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision 35ab7324
Added by Mario Rimann over 1 year ago

[BUGFIX] TCE: error message if no label has been set in TCA

Avoids an invalid SQL query if no label column is specified by the
TCA for a certain table.

Change-Id: I32ef7120464602cea56131953d53bd404d5cf217
Fixes: #17947
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9106
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision ed8e160d
Added by Mario Rimann over 1 year ago

[BUGFIX] TCE: error message if no label has been set in TCA

Avoids an invalid SQL query if no label column is specified by the
TCA for a certain table.

Change-Id: I3de10414fa73b910de350bc6a6aa65491b74d48f
Fixes: #17947
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9107
Reviewed-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1
Updated by Andreas Wolf over 1 year ago

  • Category set to Backend API
  • Status changed from New to Accepted
  • Target version deleted (0)
  • Complexity set to easy

This is still relevant for latest master (4.6-dev).

#2
Updated by Mr. Jenkins over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 of change I90211a6bbcbd00a8f0fda25c68c99a1aba3f8a1a has been pushed to the review server.
It is available at http://review.typo3.org/6992

#3
Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6992

#4
Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6992

#5
Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6992

#6
Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6992

#7
Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6992

#8
Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9105

#9
Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9106

#10
Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9107

#11
Updated by Mario Rimann over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12
Updated by Gerrit Code Review about 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9227

#13
Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9234

#14
Updated by Wouter Wolters 8 months ago

All branches are merged. Please close.

#15
Updated by Stefan Galinski 8 months ago

  • Status changed from Under Review to Closed

Also available in: Atom PDF