Feature #19809
closed
make pi_wrapInBaseClass wraps configurable
70%
Description
Background:
Plugins often use pi_wrapInBaseClass function in tslib_pibase to wrap the content with a base class. The outcome HTML looks like:
<div class="tx-extensionname-pi1">
... content ...
</div>
This is widespread, because kickstarter ships this function as default.
Problem:
The wraps can be annoying if content is empty or in cases where plugin content is used for AJAX. Unfortunately the wraps are generally not configurable.
Solution:
The appended patch adds some conditions to tslib_pibase::wrapInBaseClass to give user some control (with the precedence that general configuration is overruled by special configuration) :
- no baseWrap container for any plugin if content is empty or new TS option config.disableBaseWrap is set
- custom baseWrap container if configured in TS setup of a certain extension (using stdWrap): plugin.tx_extensionname_pi1.baseWrap
(issue imported from #M10118)
Files
Updated by Steffen Müller over 15 years ago
Documentation update:
TSref [tsref:config/->CONFIG]
Property: disableBaseWrap
Data type: boolean
Description: If set, the wrapping <div> container will be disabled in plugins which use $this->wrapInBaseClass()
Updated by Martin Holtz about 15 years ago
Updated by Martin Holtz about 15 years ago
but i really like this solution, because we have than stdWrap on plugins which uses pi_wrapInBaseClass = great enhancement:)
Updated by
Updated by Steffen Müller over 14 years ago
No.
It's pending in the core list. No decision yet.
Updated by Rafal Brzeski almost 14 years ago
What's the decission?
In which version this option appears on ?
Updated by Lina Wolf over 13 years ago
I added another patch according to discussion on the core list.
Updated by Jigal van Hemert over 13 years ago
And version six pending in core list...
Updated by Jigal van Hemert over 12 years ago
- Assignee set to Jigal van Hemert
- Target version changed from 0 to 4.7.0
- % Done changed from 0 to 70
- Complexity set to medium
Updated by Xavier Perseguers over 12 years ago
- Tracker changed from Bug to Feature
Updated by Gerrit Code Review about 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9167
Updated by Stefan Galinski about 12 years ago
Just created a new review request with the latest patch in the name of Steffen Müller. Is that ok Jigal?
Updated by
Updated by Stefan Galinski almost 12 years ago
Nobody wants to care about this feature? If so I will abandon the Gerrit review request soon. If someone wants to continue on this feature, he should look into the comments in Gerrit.
Updated by Stefan Galinski almost 12 years ago
- Status changed from Under Review to New
- Assignee deleted (
Jigal van Hemert)
Like promised I abandoned the request.
Updated by Georg Ringer about 11 years ago
- Status changed from New to Rejected
won't be fixed. extbase and fluid is in favor
Updated by Steffen Müller about 11 years ago
Wouldn't it then be consequent to remove the whole piBase stuff from core? Rejecting enhancements for piBase means it's dead anyway. sigh
Updated by Björn Jacob about 11 years ago
@Steffen: Full ACK. There are still tons of piBase extensions which will stay for years. Therefore we still need this feature.