Project

General

Profile

Actions

Bug #20712

closed

Popup dialogs are not styled in v1.7.9, FF3.0.11, TYPO3-4.2.6. Wrong values in line 3520

Added by Martin Bless over 15 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2009-07-03
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When I hit the "generate table" button the appearing popup dialog window isn't styled because the href attribute of the link tag is wron. Thus the CSS file isn't found. This doesn't prevent functioning but is dead ugly and a real usability minus.

I've figured out where and how it goes wrong but don't know how to fix it. Here is the original code. I only added explicating comment:
/** * Load the stylesheets in the dialog window * * @return void
*/
loadStyle : function () {
var head = this.dialogWindow.document.getElementsByTagName("head")[0];
var link = this.dialogWindow.document.createElement("link");
link.rel = "stylesheet";
link.type = "text/css";
link.href = HTMLArea.editorCSS;
//
// mb, 2009-07-03, Problem with FF 3.0.11, TYPO3-4.2.6, rtehtmlarea-1.7.9
// This is file: typo3_src-4.2.6/typo3/sysext/rtehtmlarea/htmlarea/htmlarea.js
// Install dir is http://www.myserver.local/CUSTOMER/
//
// at this point in JS this is what happens when I've clicked the "generate table" button:
// link.href is: "chrome://browser/CUSTOMER/typo3/sysext/t3skin/rtehtmlarea/htmlarea.css"
// _typo3_host_url is: "http://www.myserver.local"
if (link.href.indexOf("http") == -1 && HTMLArea.is_gecko) link.href = _typo3_host_url + link.href; // this is originally line 3520
// now link.href is: "http://www.myserver.localchrome//browser/CUSTOMER/typo3/sysext/t3skin/rtehtmlarea/htmlarea.css"
// which is wrong and doesn't work.
head.appendChild(link);
},

The patch I've added doesn't fix anything but only adds these comments.
(issue imported from #M11466)


Files

rtehtmlarea-bug-report-2009-07-03.diff (1.16 KB) rtehtmlarea-bug-report-2009-07-03.diff Administrator Admin, 2009-07-03 12:09

Related issues 1 (0 open1 closed)

Is duplicate of TYPO3 Core - Bug #20358: htmlArea RTE: Broken link to css in some dialogue windows with Firefox 3.0.9 and TYPO3 4.2ClosedStanislas Rolland2009-04-25

Actions
Actions #1

Updated by Stanislas Rolland over 15 years ago

I think this is a duplicate of issue #10982.

Actions #2

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF