Feature #2146
M-ID/0000132: FE-user in multiple Folders: userPID
| Status: | Accepted | Start date: | 2007-07-06 | |
|---|---|---|---|---|
| Priority: | Could have | Due date: | ||
| Assignee: | Martin Helmich | % Done: | 0% |
|
| Category: | Forum | |||
| Target version: | 1.10.0 | Estimated time: | 3.00 hours | |
| Votes: | 0 |
Description
It should be possible to use FE-users from different Folders.
Additional Information:
userPID currently only allows for a single pid. Instead it should be a comma separated list of pds to make it possible to select FE-users from different folders.
Related issues
| duplicated by mm_forum - Feature #2066: M-ID/0000338: Allow more than one userPID | Closed | 2008-04-23 |
Associated revisions
[Bug 2146] Change: Move the setting/hiding of fields from pi1::createSingleView to separate functions
[Bug 2146] Reordering of methods in tx_seminars_pi1
History
Updated by Martin Helmich over 4 years ago
- Category changed from Installation to Forum
- Status changed from New to Accepted
- Priority changed from -- undefined -- to Could have
- Target version set to 0.1.8
- Estimated time set to 3.00
Agreed. However, this poses some work since most SQL queries in the plugin are built like
$sql = '... AND pid = '.$this->getUserProfilePid();
All these queries will have to be restructured.
Probably, the best solution would be to outsource this subquery into a function getUserProfileQuery in the tx_mmforum_base class:
function getUserProfileQuery() {
return ' AND fe_users.pid IN ('.$this->getUserProfilePid().')';
}
This function is not final. Flexibility regarding the table name has to be added (for joined queries) and the return of getUserProfilePid must be validated.
Second restructure all queries in the plugin to $sql = '...'.$this->getUserProfileQuery().
Updated by Martin Helmich over 4 years ago
- Tracker changed from Bug to Feature
Updated by Martin Helmich about 4 years ago
- Target version changed from 0.1.8 to 1.9.0
Will not be integrated in 0.1.8
Updated by Alexander Stehlik over 3 years ago
It would also be very nice to have the possibility to select sub-pages recursively.
You can see what I mean when you look at the "Starting point" for plugins in TYPO3. There you can select multiple pages, and you can specify the level of the recursion (from level 1 to 4, and to infinite).
Updated by Martin Helmich about 3 years ago
- Target version changed from 1.9.0 to 1.10.0
Updated by Alexander Stehlik about 3 years ago
- File mm_forum-feature2146-0.1.patch added
Hi,
as I need this feature in a current project, I wrote a patch to the current svn trunk.
Please have a look at it. If you have any improvements, please let me know.
This patch also includes a small bugfix that prevents hidden or disabled users from beeing found in the ajax search in private messaging.
The only area I didn't look at yet, is the import module since this seems to be a standalone project now.
Kind regards,
Alex.
Updated by Alexander Stehlik about 3 years ago
- File mm_forum-feature2146-0.2.patch added
Sorry, I had a bug in the previous patch. The "recursive" option didn't work in the frontend.
A new patch is attached where this bug is fixed.
Updated by Alexander Stehlik over 2 years ago
- File ext-mm_forum-2146-multi_pid-v3.diff added
Hi,
please find a new patch attached that will apply to version 1.9.2.
Kind regards,
Alex
Updated by Hauke Hain about 2 years ago
Hi Alex,
could you create a patch for the current SVN trunk please?
It would be nice if you cast the TypoScript values before using them.
For example:
$recursive = (bool) $this->conf['userPIDRecursive']
Same for integer values (intval())
Thank you.
Hauke
Updated by Alexander Stehlik about 2 years ago
- File ext-mm_forum-2146-multi_pid-v4.diff added
Hi Hauke,
thanks for your feedback.
I attached an updated version of the patch and took your comment into account.
Most of the typecasting was done in the getPidQuery methods anyway in tx_mmforum_betools and tx_mmforum_tools, but I added an additional typecast in the install module.
By the way: At the moment the getPidQuery method is implemented in two classes (tx_mmforum_tools and tx_mmforum_betools) because it is needed in the frontend plugins and in the backend module. I didn't find a place where I can put it so that it is available in the Frondend and in the Backend. Can you give me a hint?
Kind regards,
Alex
Updated by Hauke Hain almost 2 years ago
- Assignee set to Martin Helmich