Task #24551

Adhere to CGL: t3lib_div::getUrl() instead of t3lib_div::getURL()

Added by Andreas Lappe over 2 years ago. Updated about 1 year ago.

Status:Closed Start date:2011-01-13
Priority:Should have Due date:
Assignee:Ernesto Baschny % Done:

100%
Category:-
Target version:4.6.0-beta1
TYPO3 Version:4.6 Complexity:
PHP Version:5.3
Votes: 0

Description

Even though the case is not important in PHP I think it's a matter of consistency to call it the right way. This also makes it easier for people like me who use a case-sensitive search in their editor to find the right functions…

The patches are splitted because they affect different subprojects…

(issue imported from #M17008)

getURL-typo3.diff (1 kB) Administrator Admin, 2011-01-13 14:13

getURL-t3lib.diff (17.2 kB) Administrator Admin, 2011-01-13 14:13

getURL-typo3-sysext-cms.diff (2 kB) Administrator Admin, 2011-01-13 14:13

getURL-typo3-sysext-dbal.diff (3.1 kB) Administrator Admin, 2011-01-13 14:13

getURL-typo3-sysext-em.diff (9.1 kB) Administrator Admin, 2011-01-13 14:13

getURL-typo3-sysext-impexp.diff (2.6 kB) Administrator Admin, 2011-01-13 14:14

getURL-typo3-sysext-indexed_search.diff (1.9 kB) Administrator Admin, 2011-01-13 14:14

getURL-typo3-sysext-install.diff (4.2 kB) Administrator Admin, 2011-01-13 14:14

getURL-typo3-sysext-lowlevel.diff (685 Bytes) Administrator Admin, 2011-01-13 14:14

getURL-typo3-sysext-tstemplate_info.diff (1.1 kB) Administrator Admin, 2011-01-13 14:14

getURL-typo3-sysext-version.diff (2.1 kB) Administrator Admin, 2011-01-13 14:14

getURL-typo3-sysext-workspaces.diff (1.2 kB) Administrator Admin, 2011-01-13 14:15

lowerCamelCase-getUrl-t3lib.diff (2.4 kB) Administrator Admin, 2011-01-13 16:43

lowerCamelCase-getUrl-typo3-sysext-cms.diff (605 Bytes) Administrator Admin, 2011-01-13 16:44

lowerCamelCase-getUrl-typo3-sysext-em.diff (6.2 kB) Administrator Admin, 2011-01-13 16:44

lowerCamelCase-getUrl-typo3-sysext-indexed_search.diff (627 Bytes) Administrator Admin, 2011-01-13 16:44

lowerCamelCase-getUrl-typo3-sysext-linkvalidator.diff (1.9 kB) Administrator Admin, 2011-01-13 16:44

lowerCamelCase-getUrl-typo3-sysext-lowlevel.diff (822 Bytes) Administrator Admin, 2011-01-13 16:44

lowerCamelCase-getUrl-typo3-sysext-t3editor.diff (627 Bytes) Administrator Admin, 2011-01-13 16:45

lowerCamelCase-getUrl-typo3-sysext-tsconfig_help.diff (557 Bytes) Administrator Admin, 2011-01-13 16:45

lowerCamelCase-getUrl-typo3.diff (1.7 kB) Administrator Admin, 2011-01-13 16:45

Associated revisions

Revision 19650396
Added by Ernesto Baschny almost 2 years ago

[TASK] Adhere to CGL: t3lib_div::getUrl() instead of t3lib_div::getURL()

Change-Id: If9ad418a4a70985cd661d1dd9c6f07498e833d95
Resolves: #24551
Releases: 4.6
Reviewed-on: http://review.typo3.org/3111
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

History

#1
Updated by Ernesto Baschny over 2 years ago

This is discussion-worthy. The CGL says CamelCase should also be done for acronyms like "URL" should also be CamelCases. So according to the CGL, "getUrl" is ok. Which is probably why new code is using this syntax.

So it might be worth thinking about changing t3lib_div to "getUrl()". What do you think? I'll throw the discussion in the core team. Thanks!

#2
Updated by Andreas Lappe over 2 years ago

I attached the other way around…

#3
Updated by Ernesto Baschny almost 2 years ago

  • Assignee set to Ernesto Baschny
  • Target version changed from 0 to 4.6.0-beta1

#4
Updated by Ernesto Baschny almost 2 years ago

  • Tracker changed from Bug to Task
  • Subject changed from t3lib_div::getURL() gets called as t3lib_div::getUrl() to Adhere to CGL: t3lib_div::getUrl() instead of t3lib_div::getURL()
  • Status changed from New to Accepted
  • TYPO3 Version changed from 4.5 to 4.6

#5
Updated by Mr. Hudson almost 2 years ago

Patch set 1 of change If9ad418a4a70985cd661d1dd9c6f07498e833d95 has been pushed to the review server.
It is available at http://review.typo3.org/3111

#6
Updated by Ernesto Baschny almost 2 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 0 to 100

#7
Updated by Xavier Perseguers about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF