Project

General

Profile

Actions

Bug #24588

closed

Irre: possible to hide/unhide records

Added by Georg Ringer over 13 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-01-15
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.4
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

It is not possible to hide/unhide records which are shown by using IRRE. After clicking on the hide-icon nothings happens

(issue imported from #M17052)


Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Bug #23580: Icon for hidden field doesn't work with IRREClosed2010-09-22

Actions
Related to TYPO3 Core - Bug #34303: IRRE hide/unhide broken in masterClosedOliver Hader2012-02-26

Actions
Has duplicate TYPO3 Core - Bug #33733: Show/Hide button just works if the entry has been opened at least onceClosed2012-02-07

Actions
Actions #1

Updated by Stefan Geith about 13 years ago

Same in 4.4-trunk

Actions #2

Updated by Andreas Kiessling about 13 years ago

Related to #23580
Problem is difficult to solve: If the record is expanded, the button can easily trigger the click on the checkbox like before the IRRE records were made to only load on demand.
But if it is not expanded, clicking will have no effect.
I think i have a patch lying around that includes a hidden field for "hidden" (can't remember how far i went, but nowhere near "final"), but that creates other problems: If the hidden field is displayed in the IRRE record, the hidden "hidden" field should be removed.
Additionally: pageTS should be respected as well as exclude fields for the user.
Pretty difficult to solve...

Actions #3

Updated by Stefan Geith about 13 years ago

Could the Hide/Unhide-Button do two things:
1. Toggle hidden-flag of record via ajax in DB
2. Toggle hidden-checkbox of form, but only if already loaded
Wouldn't this solve the problem ?

Actions #4

Updated by Andreas Kiessling about 13 years ago

Problem with this solution would be consistency:
All operations on the IRRE records are done when saving the form. So using ajax would change that behavior dramatically.

To make it consistent: hide the "hidden" checkbox in IRRE records and
a) either only do it with ajax or
b) trigger a hidden field

My approach was, to render a hidden input and remove that field if the record is expanded. But now you get a problem, when the visibility is toggled in the meantime. Not very elegant...

Additionally: what do you do, if the checkbox is not rendered in the expanded record? Is there a way to check this (including TCA-types, pageTS, exclude fields)?

With b), we would "only" need to disable rendering of the "hidden" field in the record. Then every record that has a "hidden"-field gets a hidden input field, unless it is not somehow disabled, what should of course also affect the visibility / clickability of the button.

Actions #5

Updated by Andreas Kiessling about 13 years ago

Forgot option c)
remove click function from the icon and only change visibility through checkbox
I fear c) will be the only solution for 4.4. For 4.5 i don't know if such a change can still go in.

Actions #6

Updated by Oliver Hader almost 13 years ago

  • Target version changed from 0 to 1264
  • TYPO3 Version changed from 4.5 to 4.4
Actions #7

Updated by Oliver Hader over 12 years ago

  • Target version changed from 1264 to 1341
Actions #8

Updated by Marcus Schwemer almost 12 years ago

Hi,

the issue is still there ;-) It's quite hard to explain editors why it does not work.

As a bugfix for existing branches I would remove the lamp from the bar. For 6.0 I would like to see the "IRRE bar" completely ajaxified,. Every action that is triggered by an icon in the bar has direct effect on the database. Why? Because the current behaviour to have to save any action is different for example from extended view in the list view. I know there is always a new page loaded, but that leads to state where another action has to be done. If I move an IRRE element I'd expect that this move is saved in the DB without hitting the disc icon.

Ciao,
Marcus

Actions #9

Updated by Andreas Kiessling almost 12 years ago

One of the big problems with ajaxifying is, that it can only work for already saved elements.
Add a new IRRE record and none of it will work.

You can already remove the lamp icon with this in the appearance array in TCA:

'enabledControls' => array(
        'hide' => FALSE,
),

Actions #10

Updated by Marcus Schwemer almost 12 years ago

I just discovered a working patch on review.typo3.org connected to issue #34303.

https://review.typo3.org/#/q/topic:34303,n,z

Please test and review.

Ciao
Marcus

Actions #11

Updated by Andreas Wolf over 11 years ago

  • Status changed from New to Resolved

Apparently resolved with #34303.

Actions #12

Updated by Ernesto Baschny almost 11 years ago

  • Target version deleted (1341)
Actions #13

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF