Mailformplus MVC

The code is part of the fillTypoScriptMarkers() method.
The if clause evaluates if the TS Object is NOT an "USER" or "USER_INT" object. In this case it calls callUserFunction otherwise cObjGetSingle.
The Problem is that the clause is always true. abstract: a!=b || a!=c

Could be false only if (b==c) which means: "USER" === "USER_INT" :-)
patch: !(a==b || a==c)

Since the TS marker is a plugin which is called through callUserFunction instead of cObjGetSingle some problems appear, particular concerning the parameters.

The code looks like this:

if(!strcmp($options,"USER") || !strcmp($options,"USER_INT")) {
    $this->settings['markers.'][$name.'.']['gp'] = $this->gp;
    $markers['###'.$name.'###'] = t3lib_div::callUserFunction($this->settings['markers.'][$name.'.']['userFunc'],$this->settings['markers.'][$name.'.'],$this,"");
} else {
    $markers['###'.$name.'###'] = $this->cObj->cObjGetSingle($this->settings['markers.'][$name],$this->settings['markers.'][$name.'.']);
}

The PHP function strcmp returns 0 if the two string are equal!
So it could be read like: if(a=='USER' || a=='USER_INT').
Thus, if the marker is a USER or a USER_INT object, callUserFunction() is called.
If the marker is a TEXT,HTML, ... object, cObjGetSingle() is called.

I think, this is the correct way to do this. Also passing he parameters to the user function should work, at least the documentation of t3lib_div states that a user function should be called this way.
Did you experience problems calling a user function?

ah, ok. Sorry, did't look at the return of strcmp. Allways was looking to get the USER object called via cObjGetSingle.

But: why do you make this differntiation? I use a USER object which throws a fatal error when called via callUserFunction. I think this is because of different parameter position of the conf in callUserFunction() and tslib_cObj.USER. btw in mailformplus all TS markers are called via cObjGetSingle.

I have to admit, that I do not remember why this distinction is made. I think we changed to callUserFunction() in th_mailformplus too.
Anyway, since callUserFunction() seems to make troubles, I will replace it with cObjGetSingle() again and the problem is solved.