Project

General

Profile

Actions

Bug #25311

closed

generating the target for imagelinkwrap fails

Added by Anonymous about 13 years ago. Updated almost 13 years ago.

Status:
Closed
Priority:
Must have
Category:
Content Rendering
Target version:
Start date:
2011-03-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

in the file for rendering the imagelinkwrap there seems to be a typo when generating the target-attribute for the link tag. atm $target is only being processed when it's not containing an actual value. it's supposed to be the other way round I guess.

oh, right, this causes trouble when trying to validate the page the imagelinkwrap is located on.

class.tslib_content.php:
1464 if(!$target) {
1465 $target = sprintf(' target="%s"', $target);
1466 } else {
1467 $target = ' target="thePicture"';
1468 }

(issue imported from #M17931)

Actions #1

Updated by Ernesto Baschny about 13 years ago

  • Category set to Content Rendering
  • Assignee set to Ernesto Baschny
  • Priority changed from Should have to Must have
  • Target version changed from 0 to 4.5.3
  • TYPO3 Version set to 4.5

This was broken during the stdWrapization in the 4.5 development.

This change (Forge's #24089) broke it: http://git.typo3.org/TYPO3v4/Core.git?a=commit;h=b90e61c1

Actions #2

Updated by Mr. Hudson about 13 years ago

Patch set 1 of change If3b34a0ca1be76d6f0fcef016858b2067e3efb1b has been pushed to the review server.
It is available at http://review.typo3.org/1329

Actions #3

Updated by Mr. Hudson about 13 years ago

Patch set 1 of change I3f3a617c72fbc022c752fffb275c8badb2d25922 has been pushed to the review server.
It is available at http://review.typo3.org/1330

Actions #4

Updated by Ernesto Baschny about 13 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Oliver Hader almost 13 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF