Feature #2544
optiona "[edit page]" command in Translation task list
| Status: | New | Start date: | 2009-02-03 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | - | |||
| Target version: | - | |||
| Has patch: | ||||
| Votes: | 0 |
Description
for simple editors, it is quite confusing the command [edit page] in the list of the Translation tasks. (also because it needs the page module (otherwise it gives error), introducing another way to do the translation.. IMO not a good choice for "easyness"
this [edit page] is given by these lines in mod2/list.php:
if ($el[0]=='pages') {
// If another page module was specified, replace the default Page module with the new one
$newPageModule = trim($GLOBALS['BE_USER']->getTSConfigVal('options.overridePageModule'));
$pageModule = t3lib_BEfunc::isModuleSetInTBE_MODULES($newPageModule) ? $newPageModule : 'web_layout';
$path_module_path = t3lib_div::resolveBackPath($GLOBALS['BACK_PATH'].'../'.substr($GLOBALS['TBE_MODULES']['_PATHS'][$pageModule],strlen(PATH_site)));
$onclick = 'parent.list_frame.location.href="'.$path_module_path.'?id='.$el[1].'"; return false;';
$pmLink = '<a href="#" onclick="'.htmlspecialchars($onclick).'" target="listframe"><i>[Edit page]</i></a>';
} else {$pmLink = '';}
i think it would be much better to make them optional.. (maybe with a TS config like):
if ( ($el[0]=='pages') AND $GLOBALS['BE_USER']->getTSConfigVal('l10nmgr.allowEditPageinTranslationtanks')) {
// If another page module was specified, replace the default Page module with the new one
$newPageModule = trim($GLOBALS['BE_USER']->getTSConfigVal('options.overridePageModule'));
$pageModule = t3lib_BEfunc::isModuleSetInTBE_MODULES($newPageModule) ? $newPageModule : 'web_layout';
$path_module_path = t3lib_div::resolveBackPath($GLOBALS['BACK_PATH'].'../'.substr($GLOBALS['TBE_MODULES']['_PATHS'][$pageModule],strlen(PATH_site)));
$onclick = 'parent.list_frame.location.href="'.$path_module_path.'?id='.$el[1].'"; return false;';
$pmLink = '<a href="#" onclick="'.htmlspecialchars($onclick).'" target="listframe"><i>[Edit page]</i></a>';
} else {$pmLink = '';}
what do you think?
stefano