Project

General

Profile

Actions

Bug #25985

closed

remove obsolete check for dir media/scripts/ in Function tslib_fe::checkFileInclude

Added by Patrick Rodacker almost 13 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-04-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

One of the path checks of the function tslib_fe::checkFileInclude checks if the includefile is within the path media/scripts/ which is obsolete:

function checkFileInclude($incFile)    {
    return !$this->TYPO3_CONF_VARS['FE']['noPHPscriptInclude']
        || substr($incFile,0,14)=='media/scripts/'
        || substr($incFile,0,4+strlen(TYPO3_mainDir))==TYPO3_mainDir.'ext/'
        || substr($incFile,0,7+strlen(TYPO3_mainDir))==TYPO3_mainDir.'sysext/'
        || substr($incFile,0,14)=='typo3conf/ext/';
}

Related issues 4 (0 open4 closed)

Related to TYPO3 Core - Bug #26133: Fix broken string replacement for media/ folderClosed2011-04-19

Actions
Related to TYPO3 Core - Bug #25028: Remove cms/tslib/media folder to TER extensionClosed2011-02-14

Actions
Related to TYPO3 Core - Task #31461: The Big Cleanup 4.7Closed2012-02-192012-02-20

Actions
Related to TYPO3 Core - Bug #43730: Update outdated description of ['FE']['noPHPscriptInclude'] in DefaultConfiguration.phpClosed2012-12-07

Actions
Actions #1

Updated by Patrick Rodacker almost 13 years ago

I think this should be also related to the task #24954

Actions #2

Updated by Gerrit Code Review about 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8850

Actions #3

Updated by Markus Klein about 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF