Bug #26090

Remove old code related to extension tstemplate_styler (sys_template:editorcfg)

Added by Patrick Rodacker about 2 years ago. Updated over 1 year ago.

Status:Needs Feedback Start date:2011-04-18
Priority:Should have Due date:
Assignee:- % Done:

100%
Category:-
Target version:-
TYPO3 Version:4.5 Complexity:
PHP Version:
Votes: 1 (View)

Description

I stumbled upon different places in the TYPO3 core where code related to the extension tstemplate_styler is still present. IMHO the code should be removed, because the extension tstemplate_styler is not shipped with the core. I don't know what is the best way to move configuration options from the extensions, but I think they should not stay in the core.

These are some issues I have identified on a quick search about this topic:

  • the field editorcfg in the record sys_template still exists.
  • configuration options $TYPO3_CONF_VARS['FE']['defaultTypoScript_editorcfg'] and $TYPO3_CONF_VARS['FE']['defaultTypoScript_editorcfg.'] still present
  • Extension Manager still supporting the settings (e.g. ext_typoscript_editorcfg.txt)

I don't know if the deprecated policy is the best way to handle this.

Associated revisions

Revision 4e7530ba
Added by Dmitry Dulepov over 1 year ago

[TASK] Remove old code related to the extension tstemplate_styler

The extension tstemplate_styler does not come with TYPO3, it is
old amd most likely unused by anybody with a modern TYPO3 version.
However fields for this extension exist in TYPO3 tables as
TEXT/BLOB. Also code exists to manage the files for the styler
but this code is either under condition, which is always false,
or never called because corresponding files do not exist any more.
Since this functionality is unused, remove it without prior
deprecation in TYPO3 4.7.

Change-Id: Ic864276be13b069838f8950e43b864f1c12b3f75
Resolves: #26090
Releases: 4.7
Reviewed-on: http://review.typo3.org/6972
Reviewed-by: Björn Pedersen
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

History

#1
Updated by Benjamin Mack about 2 years ago

Hey Patrick,

good point.

I suggest that "tstemplate_styler" should add the field and the options (via hooks) and then we need some sort of upgrade wizard. Although I have to say, that this is completely unused now (I haven't seen an installation in the last 3 ys making use of that feature anymore).

#2
Updated by Mr. Jenkins over 1 year ago

  • Status changed from New to Under Review

Patch set 1 of change Ic864276be13b069838f8950e43b864f1c12b3f75 has been pushed to the review server.
It is available at http://review.typo3.org/6972

#3
Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6972

#4
Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6972

#5
Updated by Dmitry Dulepov over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6
Updated by Benjamin Mack over 1 year ago

The change breaks the installation of the static_templates extension.
The item with UID=43 was not modified and thus has one value '' too much, please.

#7
Updated by Benjamin Mack over 1 year ago

  • Status changed from Resolved to Needs Feedback

Also available in: Atom PDF