CoreCommunity ExtensionsIncubatorDistributionsTYPO3 4.5 ProjectsTYPO3 4.6 ProjectsTYPO3 4.7 ProjectsTYPO3 6.0 ProjectsTYPO3 6.1 ProjectsTYPO3 6.2 Projects (+)

Bug #26859

paginator: setLimit() doesn't work for the first page.

Added by Sinian Zhang about 2 years ago. Updated almost 2 years ago.

Status:Resolved Start date:2011-05-17
Priority:Should have Due date:
Assignee:- % Done:

100%
Category:-
Target version:-
TYPO3 Version: Has patch:
PHP Version: Complexity:
Votes: 0

Description

Hi,

The paginator in list-view doesn't work correctly. The first page lists all the news, in stead of a limited number of news.

That is to say, the $query->setLimit() was not called for the first page. My patch should help to fix the bug.

With regards,
SZ

Classes_ViewHelpers_Widget_Controller_PaginateController.php.diff (449 Bytes) Sinian Zhang, 2011-05-17 14:50

screenshot01.png (15.9 kB) Sinian Zhang, 2011-06-03 17:30

Associated revisions

Revision bbd45fc8
Added by Georg Ringer almost 2 years ago

[BUGFIX] paginator: setLimit() at 1st page

The paginator doesn't work correctly at the
1st page.

Change-Id: Id7441c3f6d6944de08818997cff35406b20264c1
Resolves: #26859

History

#1
Updated by Georg Ringer almost 2 years ago

  • Status changed from New to Needs Feedback

I can'T really reproduce your problem.

I have 10 news per page and still set a limit of 3 in the flexforms. I will still only get 3 news.

do you also use an offeset?

thanks for your help and sorry for late response

#2
Updated by Sinian Zhang almost 2 years ago

Hi,

You could set the TS as following, and see whether the paginator in FE works correctly or not.
---
plugin.tx_news2.settings.list.paginate.itemsPerPage = 3
---

The paginator works correctly except its first page, the first page shows still all the news insteaf of a limited number(in your case 3) .

With regards,
SZ

#3
Updated by Georg Ringer almost 2 years ago

can you tell which settings do you have in the plugin's settings (flexforms) for limit and offset and which in TS.

#4
Updated by Sinian Zhang almost 2 years ago

Hi,

I have no other settings for limit or offset in flexform. (screenshot01.png)

I have only the following TS in order to test paginator.
---
plugin.tx_news2.settings.list.paginate.itemsPerPage = 3
---

with regards,
SZ

#5
Updated by Mr. Hudson almost 2 years ago

Patch set 1 of change Id7441c3f6d6944de08818997cff35406b20264c1 has been pushed to the review server.
It is available at http://review.typo3.org/2515

#6
Updated by Georg Ringer almost 2 years ago

  • Status changed from Needs Feedback to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF