Bug #27989
Wrong check in our atomic writes code
| Status: | Resolved | Start date: | 2011-07-08 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assignee: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | Cache | |||
| Target version: | TYPO3 Flow Base Distribution - 1.1 RC1 | |||
| PHP Version: | Complexity: | |||
| Has patch: | No | FLOW3 version affected: | FLOW3 1.0.0 | |
| Votes: | 0 |
Description
This is from Cache\Backend\FileBackend, similar stuff is patched into Doctrine's ProxyFactory:
if ($result === FALSE) throw new \TYPO3\FLOW3\Cache\Exception('The temporary cache file "' . $temporaryCacheEntryPathAndFilename . '" could not be written.', 1204026251);
$i = 0;
$cacheEntryPathAndFilename = $this->cacheDirectory . $entryIdentifier . $this->cacheEntryFileExtension;
while (!rename($temporaryCacheEntryPathAndFilename, $cacheEntryPathAndFilename) && $i < 5) {
$i++;
}
if ($result === FALSE) throw new \TYPO3\FLOW3\Cache\Exception('The cache file "' . $cacheEntryPathAndFilename . '" could not be written.', 1222361632);
The second check for $result is moot, because it's not set in the rename loop...
Related issues
| related to TYPO3.Flow - Bug #28733: Implement LockManager for avoiding Race Conditions | Resolved | 2011-08-04 | ||
| related to TYPO3.Flow - Task #3755: Concurrency stress testing and cache mechanism | New | 2009-06-25 | ||
| related to TYPO3.Flow - Bug #32707: Bad Bad FileBackend | Accepted | 2011-12-19 | ||
| related to TYPO3.Flow - Bug #33621: Filebackend reports error when trying to rename file due ... | Needs Feedback | 2012-02-02 |
Associated revisions
History
Updated by Karsten Dambekalns over 1 year ago
- Status changed from New to Accepted
- Assignee set to Karsten Dambekalns
Updated by Karsten Dambekalns over 1 year ago
- Target version deleted (
1230)
Updated by Karsten Dambekalns over 1 year ago
- FLOW3 version affected set to FLOW3 1.0.0
Updated by Karsten Dambekalns over 1 year ago
- Target version set to 1.1
- Has patch set to No
Updated by Karsten Dambekalns over 1 year ago
- Target version changed from 1.1 to 1.0.3
Updated by Gerrit Code Review over 1 year ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8786
Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8787
Updated by Karsten Dambekalns over 1 year ago
- Status changed from Under Review to Accepted
Updated by Gerrit Code Review over 1 year ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8931
Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8931
Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8787
Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8931
Updated by Karsten Dambekalns about 1 year ago
- Target version changed from 1.0.3 to 1.0.4
Updated by Karsten Dambekalns about 1 year ago
- Target version changed from 1.0.4 to 1.0.5
Updated by Karsten Dambekalns 12 months ago
- Target version changed from 1.0.5 to 1.1 RC1
Updated by Gerrit Code Review 11 months ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12187
Updated by Gerrit Code Review 11 months ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12187
Updated by Gerrit Code Review 11 months ago
Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12398
Updated by Karsten Dambekalns 11 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100