Bug #28271
Unit test checkDateWithInvalidDateValues fails with PHP warning
| Status: | Closed | Start date: | 2011-07-17 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | - | % Done: | 100% |
|
| Category: | - | |||
| Target version: | - | |||
| Votes: | 0 |
Description
If your TYPO3 is configured to not suppress PHP warnings, the unit test checkDateWithInvalidDateValues with data set "Not Good" of Testsuite tx_scheduler_ModuleTest fails.
As it tries to insert non-numeric values into mkstring(), this warning is raised.
We can safely suppress the output of PHP warnings for the mktime call, as afterwards its return value is checked.
Associated revisions
[BUGFIX] Unit test checkDateWithInvalidDateValues fails with PHP warning
If TYPO3 is configured to not suppress PHP warnings, the unit test
'checkDateWithInvalidDateValues with data set "Not Good"'
of Testsuite tx_scheduler_ModuleTest fails.
As it tries to insert non-numeric values into mkstring(), this warning
is raised.
We can safely suppress the output of PHP warnings for the mktime call,
as afterwards its return value is checked.
Change-Id: I7c6b9f587b574334e0096c800de98cb6ffc2033f
Resolves: #28271
Reviewed-on: http://review.typo3.org/3388
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
History
Updated by Mr. Hudson almost 2 years ago
Patch set 1 of change I7c6b9f587b574334e0096c800de98cb6ffc2033f has been pushed to the review server.
It is available at http://review.typo3.org/3388
Updated by Steffen Gebert almost 2 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset commit:57327fe38dc1019cc89459fef6170908dcd213e2.
Updated by Francois Suter 11 months ago
- Status changed from Resolved to Closed