CoreCommunity ExtensionsIncubatorDistributionsTYPO3 4.5 ProjectsTYPO3 4.6 ProjectsTYPO3 4.7 ProjectsTYPO3 6.0 ProjectsTYPO3 6.1 ProjectsTYPO3 6.2 Projects (+)

Bug #28432

httpbl does not work well

Added by Hauke Hain almost 2 years ago. Updated 10 months ago.

Status:Resolved Start date:2011-07-24
Priority:Should have Due date:
Assignee:Ronald Steiner % Done:

0%

Category:spamshied
Target version:-
Votes: 1 (View)

Description

httpbl does not work well - to be removed / replaced?

History

Updated by Peter Linzenkirchner 10 months ago

Hauke Hain wrote:

httpbl does not work well - to be removed / replaced?

it does not work at all ...

Updated by Peter Linzenkirchner 10 months ago

Hauke Hain wrote:

httpbl does not work well - to be removed / replaced?

there are a few errors in the code which causes that httpbl does not work:

this cannot work:
// first line of defense:
// Block always no matter if a form has been submittet or not
if (!$this->conf['firstLine']) {
$this->conf['firstLine'] = 'httpbl,1';
$this->check($this->conf['firstLine']);
}

$this->check($this->conf['firstLine']); is only executed, when $this->conf['firstLine'] is not defined!
correct:

// first line of defense:
// Block always no matter if a form has been submittet or not
if (!$this->conf['firstLine']) {
$this->conf['firstLine'] = 'httpbl,1';
}
$this->check($this->conf['firstLine']);

next error:
if ($first != 127 || !array_key_exists($this->type, $codes)) {
$type = 5;
}
$this
>type does not exist, so the resulting code is ever -5 => no spam.
Correct:

if ($first != 127 || !array_key_exists($this->conf['type'], $codes)) {
$type = -5;
}
Now it works. Sometimes slow because of the timeout of gethostbyname($request).

Updated by Ronald Steiner 10 months ago

  • Status changed from New to Resolved

thank you!
I just uploaded this Patch to TER.

Also available in: Atom PDF