CoreCommunity ExtensionsIncubatorDistributionsTYPO3 4.5 ProjectsTYPO3 4.6 ProjectsTYPO3 4.7 ProjectsTYPO3 6.0 ProjectsTYPO3 6.1 ProjectsTYPO3 6.2 Projects (+)

Bug #28465

Spellchecking suggests are always shown

Added by Jens Hoffrichter almost 2 years ago. Updated about 1 year ago.

Status:Closed Start date:2011-07-26
Priority:Should have Due date:
Assignee:Ingo Renner % Done:

100%
Category:Solr TYPO3 Plugin
Target version:2.0
TYPO3 Version: Has patch:
PHP Version: Tags:
Votes: 0

Description

Hi,

If the solr doesn't return spellchecking suggestions because the word is spelled correctly (return value "correctlySpelled"), the link for the suggest is still shown, but with the current page title as a suggestion, which is really confusing to the user.

It should be checked that the word wasn't actually spelled correctly before setting the suggestions.

A simple patch for this is attached :)

Regards,
Jens

solr_suggest.patch (652 Bytes) Jens Hoffrichter, 2011-07-26 11:46

History

#1
Updated by Ingo Renner almost 2 years ago

Which Solr version, and version of the extension are you using?

#2
Updated by Jens Hoffrichter almost 2 years ago

Solr 1.4.1
Solr Extension 1.3.0

Regards,
Jens

#3
Updated by Olivier Dobberkau over 1 year ago

  • Status changed from New to Accepted
  • Assignee set to Ingo Renner
  • Target version set to 2.0

Can you take care of this for the next release?

#4
Updated by Ingo Renner over 1 year ago

  • Status changed from Accepted to Resolved
  • Priority changed from Must have to Should have
  • % Done changed from 0 to 100

The correctlySpelled attribute is only provided when using spellcheck.extendedResults=true which we currently don't. Thus the error won't occur - at least I couldn't reproduce it. I included the fix anyways in case we change to extendedResults one day. Thanks!

Fixed in dkd-EAP r 89705

#5
Updated by Ingo Renner about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF