Bug #28487

ActionController ErrorAction forgets SubpackageKey

Added by Torsten almost 2 years ago. Updated almost 2 years ago.

Status:Resolved Start date:2011-07-26
Priority:Must have Due date:
Assignee:Sebastian Kurfuerst % Done:

100%
Category:MVC
Target version:TYPO3 Flow Base Distribution - 1.0 beta 2
PHP Version: Complexity:
Has patch: FLOW3 version affected:
Votes: 0

Description

The method errorAction of TYPO3\FLOW3\MVC\Controller\ActionController forwards like this:

$this->forward($referringRequest->getControllerActionName(), $referringRequest->getControllerName(), $referringRequest->getControllerPackageKey(), $referringRequest->getArguments());

better would be something like this:

$controllerPackageKey = $referringRequest->getControllerPackageKey();
if ($referringRequest->getControllerSubPackageKey() !== NULL) {
    $controllerPackageKey .= '\\' . $referringRequest->getControllerSubpackageKey();
}

$this->forward($referringRequest->getControllerActionName(), $referringRequest->getControllerName(), $controllerPackageKey, $referringRequest->getArguments());

Associated revisions

Revision 2d82dad1
Added by Sebastian Kurfuerst almost 2 years ago

[BUGFIX] (MVC): ActionController ErrorAction forgets SubpackageKey

In case a validation error happened, a forward() is done to the referring
action, which then re-displays the form.

However, when the referring action contains a subpackage key, this redirection
was broken.

Change-Id: Id4dfaea7d919ba2eb8d031be505d76815927999f
Resolves: #28487

History

#1
Updated by Sebastian Kurfuerst almost 2 years ago

  • Target version set to 1.0 beta 2

#2
Updated by Karsten Dambekalns almost 2 years ago

  • Category set to MVC

#3
Updated by Sebastian Kurfuerst almost 2 years ago

  • Status changed from New to Accepted
  • Assignee set to Sebastian Kurfuerst

I'm working on this now.

#4
Updated by Mr. Hudson almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 of change Id4dfaea7d919ba2eb8d031be505d76815927999f has been pushed to the review server.
It is available at http://review.typo3.org/4783

#5
Updated by Mr. Hudson almost 2 years ago

Patch set 2 of change Id4dfaea7d919ba2eb8d031be505d76815927999f has been pushed to the review server.
It is available at http://review.typo3.org/4783

#6
Updated by Sebastian Kurfuerst almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF