Project

General

Profile

Actions
Copy link

Feature #29342

closed

More detailed Mail from scheduler task

Added by Kay Strobach over 12 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
Candidate for Major Version
Start date:
2011-08-30
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:

Description

Having a system with thousands of pages makes it hard to decide who has to fix the broken links ;)

Currently the scheduler task sends out a mail like this:

Total broken links: 224 (last report: 224)

Page: Mandanten
All links types: 224 (last report: 224)
Internal link: 21 (last report: 20)
External link: 96 (last report: 97)

In my opinion it would be better to have more information e.g.:

+-----+-----+------------------+--------------------------------+
| pid | uid | CE Title part ...| a node value part / uri part   |
+-----+-----+------------------+--------------------------------+
| ...                                                           |
+-----+-----+------------------+--------------------------------+

The above table should not exceed 80 or 72 chars per line ;)

Beside this small feature which - big thanks for this great tool ;)

Related issues 3 (0 open — 3 closed)

Related to TYPO3 Core - Task #30296: Linkvalidator should have a hook for report markersClosedPhilipp Gampe2011-09-26

Actions
Related to TYPO3 Core - Task #90727: Migrate ValidatorTask to FluidEmailClosed2020-03-10

Actions
Related to TYPO3 Core - Feature #59502: EXT:linkvalidator hooksClosed2014-06-11

Actions
Actions
Copy link
 #1

Updated by Philipp Gampe over 12 years ago

  • Complexity changed from easy to medium

Good idea ... I don't now if I will find the time until beta3. Something for TYPO3 4.7?

Actions
Copy link
 #2

Updated by Kay Strobach over 12 years ago

would be ok either ;) - thanks for taking care

(as i thought time is over for 4.6 I've not added a target version ;) )

Actions
Copy link
 #3

Updated by Michael Miousse over 12 years ago

  • Target version set to 4.7.0

When i created the task and the mail notification i had in mind that usualy people will have sections of their site to run and there for i decide to a the page selection in the scheduler task.

The idea was to create a task for each section so you could send a notification mail to someone for a specific section of your site.

Exemple

you have a site with the following arbo:

root
>About us
>>Team
>>Presence
>>COA
>Media Center
>>press Releases
>>Multimedia Library

lets say the section About us is taken care by john smith and the media center section is taken care by jane smith, you should create 2 seperated task one for the About us section that send a notification mail to john smith and on fo the media center that send the notification to jane smith.

The general idea for this was to use the module to handel broken links so we would not have to repeate all informations about those broken links but only send a notification that there is some new broken links on the web site and that they sould go to the linkvalidator module to investigate those broken links.

This is how i saw the task system, but i'm open to see other kind of use of the tasks
Thanks for your concernes

Actions
Copy link
 #4

Updated by Kay Strobach over 12 years ago

for sure - i understand the idea - but in my scenario there too much people working in the installation to make a job for every customer.

+ page with default settings
| + customer 1
...
| + customer 300
...

The uri part can be a part of the rootline also (started from the point that is given to the task).
Another solution could be that i wrap you task and use a more generic approach.

Anyway there too much clicks (to reinspect the links) for many users, if the information can be shipped by mail.

Thanks for your great work
Kay

Actions
Copy link
 #5

Updated by Soren Malling over 12 years ago

May I suggest a hook instead - then one can decide what a detailed mail should consist of? It will be hard to decide, what markers should go in to the template on behalf of every single user :) A hook, makes it possible to customize it

Actions
Copy link
 #6

Updated by Kay Strobach over 12 years ago

mhmm, hook would be ok either - but a default "extended report", which is selectable in em / task setup would also be great.

regards
Kay

Actions
Copy link
 #7

Updated by Philipp Gampe over 12 years ago

I would suggest adding another checkmark to the schedular task configuration "Extended report" and then just add support for a subpart with markers.
As the collection of detailed info takes more time, I think this checkbox should be there.

A more automated solution would be to parse the template first and then get the information for all used markers like it is done in cal (calendar base).

A hook should be added in addition.

Actions
Copy link
 #8

Updated by Kay Strobach over 12 years ago

mhmm what about the following solution:

checkbox + field for selecting a file from fileadmin

use the fluid template if checkbox is activated.

Actions
Copy link
 #9

Updated by Philipp Gampe over 12 years ago

Well, the field for selecting a template file is already there, AFAIK a file chooser is still missing.

Actions
Copy link
 #10

Updated by Kay Strobach over 12 years ago

very cool - do you use the FLUID way to render the template or the oldstyle one with markers?

FLUID standalone Doku ;)

http://forge.typo3.org/projects/typo3v4-mvc/wiki/How_to_use_the_Fluid_Standalone_view_to_render_template_based_emails

The fileselector is just a gimmick for me ;) - not important, as most admins know what they do ;)

Thanks in advice
Kay

Actions
Copy link
 #11

Updated by Soren Malling over 12 years ago

I've created a "standalone" issue for the hooks, as I see this as a separate change for linkvalidator (#30296)

Please test and vote: http://review.typo3.org/5354

I have "twitted" with Xavier, this is not considered a feature, and will be a part of TYPO3 4.6 if merged before RC1 (11/10)

Actions
Copy link
 #12

Updated by Philipp Gampe over 12 years ago

  • Status changed from New to On Hold

We can deal with this after 4.7.

Actions
Copy link
 #13

Updated by Philipp Gampe about 12 years ago

  • Target version changed from 4.7.0 to 6.0.0
Actions
Copy link
 #14

Updated by Michael Stucki over 10 years ago

  • Category set to Linkvalidator
Actions
Copy link
 #15

Updated by Michael Stucki over 10 years ago

  • Project changed from 1510 to TYPO3 Core
  • Category changed from Linkvalidator to Linkvalidator
Actions
Copy link
 #16

Updated by Mathias Schreiber about 9 years ago

  • Status changed from On Hold to Needs Feedback
  • Assignee set to Mathias Schreiber

I think we can safely assume today if "after 4.7.0".
Shall we continue?

Actions
Copy link
 #17

Updated by Alexander Opitz almost 9 years ago

  • Target version deleted (6.0.0)

What's the state of this issue?

Actions
Copy link
 #18

Updated by Alexander Opitz over 8 years ago

  • Status changed from Needs Feedback to New
  • Assignee deleted (Mathias Schreiber)
  • Target version set to 8 LTS
Actions
Copy link
 #19

Updated by Riccardo De Contardi about 7 years ago

  • Target version changed from 8 LTS to 9.0
Actions
Copy link
 #20

Updated by Susanne Moog about 6 years ago

  • Target version deleted (9.0)
Actions
Copy link
 #21

Updated by Kay Strobach about 6 years ago

  • PHP Version deleted (5.3)

is someone still interested in his thingy?

Actions
Copy link
 #22

Updated by Georg Ringer about 6 years ago

plans are to rewrite linkvalidator completly, so yes

Actions
Copy link
 #23

Updated by Benni Mack about 4 years ago

  • Target version set to 10 LTS
Actions
Copy link
 #24

Updated by Georg Ringer about 4 years ago

  • Related to Task #90727: Migrate ValidatorTask to FluidEmail added
Actions
Copy link
 #25

Updated by Georg Ringer about 4 years ago

Actions
Copy link
 #26

Updated by Sybille Peters about 4 years ago

I don't think having a list like that above with the list of broken links would be very helpful. You get a few broken links. Maybe have that, but more of an overview with aggregated information as well?

I think, to decide "who" must fix: aggregated information would be more useful, e.g.

  • Number of broken links per subpages
  • Number of broken links per editor / group (that is probably not a good idea, GDPR etc. wise)

Now, in a big site with a number of editors and groups which partially overlap, this is not very helpful either. I have a site with this kind of usecase.

Previously, if you don't enter 1 pid in the scheduler task but several, you already got an aggregated list. (I would add an example here, but it seems the behavior has changed and you can no longer add several pids in the scheduler, see #90848).

Actions
Copy link
 #27

Updated by Georg Ringer about 4 years ago

  • Target version changed from 10 LTS to Candidate for Major Version
Actions
Copy link
 #28

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #29

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #30

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #31

Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #32

Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #33

Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #34

Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #35

Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #36

Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #37

Updated by Gerrit Code Review over 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #38

Updated by Gerrit Code Review over 3 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #39

Updated by Gerrit Code Review over 3 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #40

Updated by Gerrit Code Review over 3 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #41

Updated by Gerrit Code Review over 3 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #42

Updated by Gerrit Code Review over 3 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #43

Updated by Gerrit Code Review over 3 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #44

Updated by Gerrit Code Review over 3 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #45

Updated by Gerrit Code Review over 3 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549

Actions
Copy link
 #46

Updated by Oliver Bartsch over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #47

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF