Project

General

Profile

Actions

Bug #29695

closed

t3lib_Compressor fails with external files

Added by Xavier Perseguers over 12 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
Start date:
2011-09-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Externally-referenced files such as

page.includeJSlibs { 
    jquery = http://code.jquery.com/jquery-1.6.1.min.js
    jquery.external = 1
}

fail to be concatenated/compressed because the "external" flag is lost in tslib_pagegen, around line 693.

This is the case if one activates compression and/or concatenation:

config.compressJs = 1
config.concatenateJs = 1

The compressor then searches for a local file, cannot find it by prepending TYPO3_path and thus fails to handle it.

If compression/concatenation is not deactivated, it should naturally be locally stored prior to being concatenated/compressed or should alternatively be dynamically retrieved and compressed/concatenated on the fly.

The same applies for external CSS files


Related issues 5 (0 open5 closed)

Related to TYPO3 Core - Bug #29832: Bugfix #29695 breaks backend loginClosed2011-09-15

Actions
Related to TYPO3 Core - Bug #43606: Wrong path when compressing and merging external js filesClosed2012-12-05

Actions
Related to TYPO3 Core - Bug #53123: Is compressing external JS and CSS files necessary by default? ClosedOliver Hader2013-10-25

Actions
Related to TYPO3 Core - Bug #52597: Compressor: Fetch external files correctlyRejected2013-10-07

Actions
Precedes TYPO3 Core - Bug #38146: External file concatenation takes place on every page requestClosed2012-06-18

Actions
Actions #1

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change Idd02d85c98811167cccafd2e6a6a96fefda6a936 has been pushed to the review server.
It is available at http://review.typo3.org/4924

Actions #2

Updated by Xavier Perseguers over 12 years ago

  • Status changed from New to Under Review
  • Assignee set to Xavier Perseguers
Actions #3

Updated by Xavier Perseguers over 12 years ago

Configuration options for compressor: http://wiki.typo3.org/TYPO3_4.6#JS.2FCSS_Compression

Actions #4

Updated by Xavier Perseguers over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
  • Complexity set to easy
Actions #5

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF