Bug #29904
closed
t3lib_Compressor should not fix absolute paths in CSS
100%
Description
If absolute paths are used in CSS and compression is enabled, t3lib_Compressor prepends the paths with the relative path to the compressed file, regardless of the path being absolute or not. This leads to false paths like "../../typo3temp/compressor//fileadmin/templates[...]".
Therefore I think that the method "findAndReplaceUrlPathsByRegex" should also check if the paths are absolute (start with "/") before replacing them.
Patchset will be submitted shortly.
Updated by Mr. Hudson over 12 years ago
Patch set 1 of change I101d11235d42e10bc1f15868aca4af5eebd885ca has been pushed to the review server.
It is available at http://review.typo3.org/5002
Friendly ghost note: This patch set is invalid - use 5051 instead
Updated by Mr. Hudson over 12 years ago
Patch set 1 of change I36355f46da53d167a9fb318228383a6181920398 has been pushed to the review server.
It is available at http://review.typo3.org/5051
Updated by Andreas Bouche over 12 years ago
Please excuse me, I accidently pushed to a new changeID.
Is it Ok to move on with the new one, or should I amend the old one?
Updated by Oliver Hader over 12 years ago
- Status changed from New to Under Review
Updated by Oliver Hader over 12 years ago
- Target version set to 4.5.7
- TYPO3 Version changed from 4.6 to 4.5
- PHP Version set to 5.3
Updated by Xavier Perseguers over 12 years ago
- Status changed from Under Review to Needs Feedback
- % Done changed from 0 to 60
Change has been successfully cherry-picked as 9f26f86303faecbc506c22ec34974f1bd877f206.
Please provide and submit patches for 4.5 and 4.4.
Updated by Andreas Bouche over 12 years ago
- Status changed from Needs Feedback to Resolved
- % Done changed from 60 to 100
Applied in changeset 9f26f86303faecbc506c22ec34974f1bd877f206.
Updated by Xavier Perseguers over 12 years ago
- Status changed from Resolved to Needs Feedback
- % Done changed from 100 to 60
Sorry, but the patch is marked as targetting 4.6, 4.5 and 4.4 and only the patch for 4.6 got merged!
Updated by Mr. Hudson over 12 years ago
Patch set 1 of change I4f306e314cab748a24d3e25fcb9a86a28e12384a has been pushed to the review server.
It is available at http://review.typo3.org/5123
Updated by Mr. Hudson over 12 years ago
Patch set 1 of change I1c52b2c4f39a8d4c3316ece0c4ca0284956e4743 has been pushed to the review server.
It is available at http://review.typo3.org/5124
Updated by Andreas Bouche over 12 years ago
Patchsets for 4.5 and 4.4 have been submitted.
Updated by Andreas Bouche over 12 years ago
- Status changed from Needs Feedback to Resolved
- % Done changed from 60 to 100
Applied in changeset 161e42149be8d215a361b2a13ace564854aa084a.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed