Bug #30212
Wrong marker in notification mail message: USER_FULLNAME vs. USER_REALNAME
| Status: | Resolved | Start date: | 2011-09-22 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | Bugs | |||
| Target version: | - | |||
| TYPO3 Version: | 4.5 | PHP Version: | ||
| Votes: | 0 |
Description
The language file from versions has this line as default message that is sent as the notification mail:
State was changed by ###USER_FULLNAME### (username: ###USER_USERNAME###)
but the marker that is replaced in the class.tx_version_tcemain.php is ###USER_REALNAME###
###USER_REALNAME### probably makes more sense, since that is the field from be_users table
History
Updated by Jigal van Hemert over 1 year ago
It seems more practical to me to change the marker in tx_version_tcemain::notifyStageChange() simply because the template is in the translation server. 'Labels' should not be changed once they are used because this would require changes in all translations too.
Updated by Andreas Kiessling over 1 year ago
Ok, good point. I don't think that too many workspace users have customized the message anyway.
Updated by Mr. Hudson over 1 year ago
Patch set 1 of change Ibc50e4ab881ab21b590d394ebf7dc59a0b000e6e has been pushed to the review server.
It is available at http://review.typo3.org/5613
Updated by Tolleiv Nietsch over 1 year ago
- Status changed from New to Under Review
Updated by Tolleiv Nietsch over 1 year ago
Please test the patch - I'd suggest to keep both markers for some time.
Updated by Mr. Hudson over 1 year ago
Patch set 2 of change Ibc50e4ab881ab21b590d394ebf7dc59a0b000e6e has been pushed to the review server.
It is available at http://review.typo3.org/5613
Updated by Tolleiv Nietsch over 1 year ago
- Status changed from Under Review to Resolved