CoreCommunity ExtensionsIncubatorDistributionsTYPO3 4.5 ProjectsTYPO3 4.6 ProjectsTYPO3 4.7 ProjectsTYPO3 6.0 ProjectsTYPO3 6.1 ProjectsTYPO3 6.2 Projects (+)

Bug #30430

Order module: Display of order id broken

Added by Marc Wöhlken over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2011-09-29
Priority:Must have Due date:
Assignee:Benny Schimmer % Done:

100%
Category:- Spent time: -
Target version:-
Votes: 2 (View)

Description

Using TYPO 4.5.6 and commerce trunk revision 52444 the display of the order id is broken in module orders.

Instead of the id the following is displayed:
<a href="#" onclick="window.location.href='../../../../typo3/alt_doc.php?returnUrl=%2Ftypo3conf%2Fex...

This seems to be caused by cropped an wrongly escaped javascript as the source html code looks like this:
<td nowrap="nowrap" class="" colspan="2"><a href="#" onclick="window.location.href='../../../../typo3/alt_doc.php?returnUrl=%2Ftypo3conf%2Fex...</td>

30430_commerce.diff (1.4 kB) Marc Wöhlken, 2011-09-29 15:08

Related issues

related to commerce - Bug #13791: mod_orders links are broken New 2011-03-11
related to commerce - Bug #13790: order_id broken in mod_orders for TYPO3 4.5.2 (with fix!!!) Closed 2011-03-11

Associated revisions

Revision 55122
Added by Georg Schönweger over 1 year ago

Fixed Bug #30430 - Order module: Display of order id broken

Revision 55122
Added by Georg Schönweger over 1 year ago

Fixed Bug #30430 - Order module: Display of order id broken

History

#1
Updated by Marc Wöhlken over 1 year ago

The problem seems to reside in lib/class.tx_commerce_order_localrecordlist.php

In method renderListRow() the field order_id does not get special treatment and finally gets escaped.

Suggested fix:
Add special treatment for field order_id, unified diff against revision 52444 added.

#2
Updated by Benny Schimmer over 1 year ago

  • Status changed from New to Under Review
  • Assignee set to Benny Schimmer

I had the same issue with 4.5.6

The Patch fixes the problem.

+1 by reading and testing

I'll open a RFC in the team-list.

Thanks for your help

#3
Updated by Marc Wöhlken over 1 year ago

Hi Benny,
thanks for your feedback. If the patch is O.K. I would suggest refactoring the renderListRow() method to use a php case construct instead of the now used if-elseif-elseif-elseif... coding.

#4
Updated by Robert Wildling over 1 year ago

Hi,

Implementing the diff in a 0.12.7 file results in displaying no order number at all.

Furthermore:
Moving an order from "income" to another state of the product does not work.

I sincerely ask for a patch that works with 0.12.7 on TYPO3 4.5.x! Thank you!

#5
Updated by Marc Wöhlken over 1 year ago

Hi Robert,
the patch is meant to be used against version 0.13.0.

Regards
Marc

#6
Updated by Robert Wildling over 1 year ago

Hi, Marc,

I understood that it is only for 0.13, but 0.12.7 isn't working either. So I ask if it is possible to provide patch for the current TER version 0.12.7, too?

Thanks,
Robert

#7
Updated by Georg Schönweger over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset r55122.

Also available in: Atom PDF