Apache Solr for TYPO3 CMS

How to reproduce¶

Default is 10 results per page.

1. Use switch to set results per page to a different value; search results reload with say 20 results
2. Use switch to set results per page back to default value; search results reload with &tx_solr[resultsPerPage]=20 added to the URL. Now the paginator links include &tx_solr[resultsPerPage]=20
3. Use switch to set results per page to different value; search results reload with &tx_solr[resultsPerPage]=10 added to the URL
   Now the paginator links include &tx_solr[resultsPerPage]=10. The paginator itself works, but each time the first page of the search results is displayed.

The cause of the problem¶

In tx_solr_pi_results_ResultsCommand::getResultsPerPageSwitch() the action URL of the results per page switch includes the piVars. This includes the tx_solr[resultsPerPage].
However, every time this variable occurs in either POST or GET this is seen as a change in this setting; tx_solr[page] is now ignored (considered to be zero) and the first page result page is shown.
The paginator (extension pagebrowse) doesn't ignore tx_solr[page].

Solution¶

Unset the resultsPerPage and page piVars in the action URL:

$form = array(
  'action' => $this->parentPlugin->pi_linkTP_keepPIvars_url(
    array(
      'resultsPerPage' => '',
      'page' => '',
    )
  )
);

The whole concept of magically disappearing form variables is rather error prone. If a form is changed from post to get method these problems occur mainly because the pagebrowse extension doesn't support magically disappearing variables and will transport them to the next page.