Bug #31502
Validation during persistence got lost in Doctrine addition
| Status: | Resolved | Start date: | 2011-11-02 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assignee: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | Validation | |||
| Target version: | TYPO3 Flow Base Distribution - 1.0.2 | |||
| PHP Version: | Complexity: | |||
| Has patch: | No | FLOW3 version affected: | FLOW3 1.0.0 | |
| Votes: | 1 (View) |
Description
When Doctrine 2 was introduced our own persistence backend was removed - but it was the place where validation upon persistence was invoked. This was not discovered as there was no test covering this and argument validation is still working.
Related issues
| related to TYPO3.Flow - Feature #31373: Annotation to enforce validation on setter | Rejected | 2011-10-28 | ||
| related to TYPO3.Flow - Bug #32830: Validation on persist breaks with Doctrine Lazy Loading P... | Resolved | 2011-12-24 |
Associated revisions
[TASK] Move ObjectValidationFailedException out of Generic
The exception is not specific to generic persistence, thus it should
not be inside the Generic namespace.
Change-Id: I0651e3fcf361bb0dd50b2a6e3f02e494d075e27f
Related: #31502
Releases: 1.0, 1.1
[BUGFIX] Make validation upon persistence work again
The validation upon persistence was dropped (more or less by accident)
when we switched to Doctrine. This change brings it back.
In addition it fixes the exception message produced in the generic
AbstractBackend when validation fails.
Change-Id: Ifb4dd252a490c0999a211867a5665a9cb6529796
Fixes: #31502
Releases: 1.0, 1.1
[BUGFIX] Make validation upon persistence work again
The validation upon persistence was dropped (more or less by accident)
when we switched to Doctrine. This change brings it back.
In addition it fixes the exception message produced in the generic
AbstractBackend when validation fails.
Change-Id: If23af21f8cc148012a24acb15aab1d83ddb2af74
Fixes: #31502
Releases: 1.0, 1.1
History
Updated by Karsten Dambekalns over 1 year ago
- Target version changed from 1.0.1 to 1.0.2
Updated by Mr. Jenkins over 1 year ago
Patch set 1 of change Ifb4dd252a490c0999a211867a5665a9cb6529796 has been pushed to the review server.
It is available at http://review.typo3.org/6988
Updated by Karsten Dambekalns over 1 year ago
- Status changed from Accepted to Under Review
Updated by Karsten Dambekalns over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b809a3951f44558eb44989008ae8bab528ca5852.
Updated by Gerrit Code Review over 1 year ago
- Status changed from Resolved to Under Review
Patch set 1 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/7142
Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/7142
Updated by Karsten Dambekalns over 1 year ago
- Status changed from Under Review to Resolved
Applied in changeset 3522f1b264b022a5fabc2dc9c7a05a82c88b5d67.